[turbofan] Enable BytecodeGraphBuilder by default.

test/cctest/compiler/function-tester.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/cctest/compiler/function-tester.h"
 
 #include "src/ast/ast-numbering.h"
 #include "src/compilation-info.h"
 #include "src/compiler.h"
 #include "src/compiler/linkage.h"
@@ skipping 143 matching lines @@
     FunctionTester f(graph, param_count);
     p = *f.function;
   }
   return Handle<JSFunction>(p);  // allocated in outer handle scope.
 }
 
 Handle<JSFunction> FunctionTester::Compile(Handle<JSFunction> function) {
   Zone zone(function->GetIsolate()->allocator());
   ParseInfo parse_info(&zone, function);
   CompilationInfo info(&parse_info, function);
+
+  info.SetOptimizing();
   info.MarkAsDeoptimizationEnabled();
-
-  if (!FLAG_turbo_from_bytecode) {
-    CHECK(Parser::ParseStatic(info.parse_info()));
-  }
-  info.SetOptimizing();
   if (flags_ & CompilationInfo::kNativeContextSpecializing) {
     info.MarkAsNativeContextSpecializing();
   }
   if (flags_ & CompilationInfo::kInliningEnabled) {
     info.MarkAsInliningEnabled();
   }
-  if (FLAG_turbo_from_bytecode) {
-    CHECK(Compiler::EnsureBytecode(&info));
+  if (Compiler::EnsureBytecode(&info)) {

[rmcilroy, 2016/10/06 14:22:57]

Just thinking about this again - this basically makes it impossible to use the
ASTGraphBuilder even when turbo_from_bytecode is false, right? This means we
can't do (local) experiments comparing graphs built with ASTGraphBuilder and
BytecodeGraphBuilder. Should we allow that ability until we've got rid of all
the regressions between BCGB and ASTGraphBuilder? 

[Michael Starzinger, 2016/10/06 14:26:12]

This is true for cctest, yes. But compiler.cc still has support for
--noturbo-from-bytecode for (local) experimentation via the d8 shell.

     info.MarkAsOptimizeFromBytecode();
   } else {
-    CHECK(Compiler::Analyze(info.parse_info()));
+    CHECK(Compiler::ParseAndAnalyze(info.parse_info()));
     CHECK(Compiler::EnsureDeoptimizationSupport(&info));
   }
   JSFunction::EnsureLiterals(function);
 
   Handle<Code> code = Pipeline::GenerateCodeForTesting(&info);
   CHECK(!code.is_null());
   info.dependencies()->Commit(code);
   info.context()->native_context()->AddOptimizedCode(*code);
   function->ReplaceCode(*code);
   return function;
@@ skipping 11 matching lines @@
 
   Handle<Code> code = Pipeline::GenerateCodeForTesting(&info, graph);
   CHECK(!code.is_null());
   function->ReplaceCode(*code);
   return function;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8