runtime/vm/profiler.h - Issue 2363413004: VM: Avoid allocating strings when disassembling code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/profiler.h

Issue 2363413004: VM: Avoid allocating strings when disassembling code. (Closed)

Patch Set: addressed comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/profiler.h

diff --git a/runtime/vm/profiler.h b/runtime/vm/profiler.h

index be4f0498a21597892dd3f5af43f8a9eed5201c60..529a193992fb1da176e8419c14dcfa02cbb4e937 100644

--- a/runtime/vm/profiler.h

+++ b/runtime/vm/profiler.h

@@ -434,8 +434,7 @@ class CodeDescriptor : public ZoneAllocated {

}

const char* Name() const {

- const String& name = String::Handle(code_.Name());

- return name.ToCString();

+ return code_.Name();

}

bool Contains(uword pc) const {

« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/profiler_service.cc » ('j') | no next file with comments »