VM: Avoid allocating strings when disassembling code.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 4910 matching lines @@
   enum {
     kInvalidPc = -1
   };
 
   uword GetLazyDeoptPc() const;
 
   // Find pc, return 0 if not found.
   uword GetPcForDeoptId(intptr_t deopt_id, RawPcDescriptors::Kind kind) const;
   intptr_t GetDeoptIdForOsr(uword pc) const;
 
-  RawString* Name() const;
-  RawString* QualifiedName() const;
+  const char* Name() const;
+  const char* QualifiedName() const;
 
   int64_t compile_timestamp() const {
 #if defined(DART_PRECOMPILED_RUNTIME)
     return 0;
 #else
     return raw_ptr()->compile_timestamp_;
 #endif
   }
 
   intptr_t lazy_deopt_pc_offset() const {
@@ skipping 856 matching lines @@
   virtual RawString* Name() const {
     return BuildName(kInternalName);
   }
 
   // The name of this type, including the names of its type arguments, if any.
   // Names of internal classes are mapped to their public interfaces.
   virtual RawString* UserVisibleName() const {
     return BuildName(kUserVisibleName);
   }
 
-  // Same as user visible name, but including the URI of each occuring type.
-  // Used to report errors involving types with identical names.
-  virtual RawString* UserVisibleNameWithURI() const;
-
   // Returns a formatted list of occuring types with their URI.
   virtual RawString* EnumerateURIs() const;
 
   virtual intptr_t Hash() const;
 
   // The name of this type's class, i.e. without the type argument names of this
   // type.
   RawString* ClassName() const;
 
   // Check if this type represents the 'dynamic' type or if it is malformed,
@@ skipping 1135 matching lines @@
                    intptr_t len);
   static void Copy(const String& dst,
                    intptr_t dst_offset,
                    const String& src,
                    intptr_t src_offset,
                    intptr_t len);
 
   static RawString* EscapeSpecialCharacters(const String& str);
   // Encodes 'str' for use in an Internationalized Resource Identifier (IRI),
   // a generalization of URI (percent-encoding). See RFC 3987.
-  static RawString* EncodeIRI(const String& str);
+  static const char* EncodeIRI(const String& str);
   // Returns null if 'str' is not a valid encoding.
   static RawString* DecodeIRI(const String& str);
   static RawString* Concat(const String& str1,
                            const String& str2,
                            Heap::Space space = Heap::kNew);
   static RawString* ConcatAll(const Array& strings,
                               Heap::Space space = Heap::kNew);
   // Concat all strings in 'strings' from 'start' to 'end' (excluding).
   static RawString* ConcatAllRange(const Array& strings,
                                    intptr_t start,
@@ skipping 2024 matching lines @@
 
 inline void TypeArguments::SetHash(intptr_t value) const {
   // This is only safe because we create a new Smi, which does not cause
   // heap allocation.
   StoreSmi(&raw_ptr()->hash_, Smi::New(value));
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_