Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: runtime/vm/compiler.cc

Issue 2363413004: VM: Avoid allocating strings when disassembling code. (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/disassembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/block_scheduler.h" 10 #include "vm/block_scheduler.h"
(...skipping 1323 matching lines...) Expand 10 before | Expand all | Expand 10 after
1334 Code::Handle(function.CurrentCode()).PayloadStart(), 1334 Code::Handle(function.CurrentCode()).PayloadStart(),
1335 Code::Handle(function.CurrentCode()).Size(), 1335 Code::Handle(function.CurrentCode()).Size(),
1336 per_compile_timer.TotalElapsedTime()); 1336 per_compile_timer.TotalElapsedTime());
1337 } 1337 }
1338 1338
1339 if (FLAG_support_debugger) { 1339 if (FLAG_support_debugger) {
1340 isolate->debugger()->NotifyCompilation(function); 1340 isolate->debugger()->NotifyCompilation(function);
1341 } 1341 }
1342 1342
1343 if (FLAG_disassemble && FlowGraphPrinter::ShouldPrint(function)) { 1343 if (FLAG_disassemble && FlowGraphPrinter::ShouldPrint(function)) {
1344 SafepointOperationScope safepoint_scope(thread);
1345 NoHeapGrowthControlScope no_growth_control;
1346 Disassembler::DisassembleCode(function, optimized); 1344 Disassembler::DisassembleCode(function, optimized);
1347 } else if (FLAG_disassemble_optimized && 1345 } else if (FLAG_disassemble_optimized &&
1348 optimized && 1346 optimized &&
1349 FlowGraphPrinter::ShouldPrint(function)) { 1347 FlowGraphPrinter::ShouldPrint(function)) {
1350 SafepointOperationScope safepoint_scope(thread);
1351 NoHeapGrowthControlScope no_growth_control;
1352 Disassembler::DisassembleCode(function, true); 1348 Disassembler::DisassembleCode(function, true);
1353 } 1349 }
1354 1350
1355 DEBUG_ONLY(CheckInliningIntervals(function)); 1351 DEBUG_ONLY(CheckInliningIntervals(function));
1356 return Error::null(); 1352 return Error::null();
1357 } else { 1353 } else {
1358 Thread* const thread = Thread::Current(); 1354 Thread* const thread = Thread::Current();
1359 StackZone stack_zone(thread); 1355 StackZone stack_zone(thread);
1360 Error& error = Error::Handle(); 1356 Error& error = Error::Handle();
1361 // We got an error during compilation or it is a bailout from background 1357 // We got an error during compilation or it is a bailout from background
(...skipping 949 matching lines...) Expand 10 before | Expand all | Expand 10 after
2311 2307
2312 2308
2313 bool BackgroundCompiler::IsDisabled() { 2309 bool BackgroundCompiler::IsDisabled() {
2314 UNREACHABLE(); 2310 UNREACHABLE();
2315 return true; 2311 return true;
2316 } 2312 }
2317 2313
2318 #endif // DART_PRECOMPILED_RUNTIME 2314 #endif // DART_PRECOMPILED_RUNTIME
2319 2315
2320 } // namespace dart 2316 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/disassembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698