VM: Avoid allocating strings when disassembling code.

VM: Avoid allocating strings when disassembling code.

For code objects, don't allocate symbol strings when printing the disassembly.

Don't try to make disassembling work with background compilation -- instead make sure that we don't allocate on the Dart heap while disassembling.

Add NoSafepointScope around disassemble functions to assert that no allocation happens.

Also, remove some dead code from object.cc.

BUG=#27430
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/4bd534191a2b011652ee208ad9e4225f5017e5a2

[Florian Schneider, 2016-09-27 17:39:43]

Description was changed from

==========
VM: Avoid allocating symbol strings when disassembling code.

For code objects, don't allocate symbol strings when printing the disassembly.

Allocating symbols while disassembling also can cause a deadlock.

Also, remove some dead code from object.cc.

BUG=#27430
==========

to

==========
VM: Avoid allocating strings when disassembling code.

For code objects, don't allocate symbol strings when printing the disassembly.

Don't try to make disassembling work with background compilation -- instead make
sure that we don't allocate on the Dart heap while disassembling.

Add NoSafepointScope around disassemble functions to assert that no allocation
happens.

Also, remove some dead code from object.cc.

BUG=#27430
==========

[Florian Schneider, 2016-09-27 18:14:40]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-09-27 19:21:12]

lgtm

https://codereview.chromium.org/2363413004/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2363413004/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20485: cstr[cstr_len - 1] = '\0';
I'd prefer using the cursor.
cstr[index] = '\0';

[Florian Schneider, 2016-09-27 19:35:06]

https://codereview.chromium.org/2363413004/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/2363413004/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:20485: cstr[cstr_len - 1] = '\0';
On 2016/09/27 19:21:12, rmacnak wrote:
> I'd prefer using the cursor.
> cstr[index] = '\0';

Done.

[Florian Schneider, 2016-09-27 19:43:10]

Description was changed from

==========
VM: Avoid allocating strings when disassembling code.

For code objects, don't allocate symbol strings when printing the disassembly.

Don't try to make disassembling work with background compilation -- instead make
sure that we don't allocate on the Dart heap while disassembling.

Add NoSafepointScope around disassemble functions to assert that no allocation
happens.

Also, remove some dead code from object.cc.

BUG=#27430
==========

to

==========
VM: Avoid allocating strings when disassembling code.

For code objects, don't allocate symbol strings when printing the disassembly.

Don't try to make disassembling work with background compilation -- instead make
sure that we don't allocate on the Dart heap while disassembling.

Add NoSafepointScope around disassemble functions to assert that no allocation
happens.

Also, remove some dead code from object.cc.

BUG=#27430
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4bd534191a2b011652ee208ad9e4225f5017e5a2
==========

[Florian Schneider, 2016-09-27 19:43:12]

Committed patchset #4 (id:60001) manually as
4bd534191a2b011652ee208ad9e4225f5017e5a2 (presubmit successful).