Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2363383002: Move empty-cells to be generated in ComputedStyleBase (Closed)

Created:
4 years, 2 months ago by sashab
Modified:
4 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move empty-cells to be generated in ComputedStyleBase Move the inherited property empty-cells and its enum, EEmptyCells, to be generated in ComputedStyleBase. BUG=628043 Committed: https://crrev.com/6789581214e5edc19182733d7c01742cbe8467e5 Cr-Commit-Position: refs/heads/master@{#431834}

Patch Set 1 #

Patch Set 2 : Rebase after reformatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.in View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 4 chunks +1 line, -13 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
sashab
4 years, 2 months ago (2016-09-26 05:38:50 UTC) #4
rune
lgtm
4 years, 2 months ago (2016-09-26 07:47:39 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2367273003 Patch 1). Please resolve the dependency and ...
4 years, 2 months ago (2016-09-30 03:02:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363383002/1
4 years, 2 months ago (2016-10-04 23:50:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/80507) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-04 23:53:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363383002/20001
4 years, 1 month ago (2016-11-14 05:45:20 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 05:49:42 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 05:53:35 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6789581214e5edc19182733d7c01742cbe8467e5
Cr-Commit-Position: refs/heads/master@{#431834}

Powered by Google App Engine
This is Rietveld 408576698