Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2363363002: Add VisiblePosition validity checks to VisibleUnits.cpp (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add VisiblePosition validity checks to VisibleUnits.cpp BUG=648949 Committed: https://crrev.com/1985713ab7e640a5d5de02a579e10aed85eae34a Cr-Commit-Position: refs/heads/master@{#421064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -19 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 52 chunks +71 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-09-26 04:49:44 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-09-26 05:22:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363363002/1
4 years, 2 months ago (2016-09-26 23:39:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 01:08:25 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 01:10:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1985713ab7e640a5d5de02a579e10aed85eae34a
Cr-Commit-Position: refs/heads/master@{#421064}

Powered by Google App Engine
This is Rietveld 408576698