Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 2363353003: Fix bufferIndex check in VulkanWindowContext (Closed)

Created:
4 years, 2 months ago by egdaniel
Modified:
4 years, 2 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix bufferIndex check in VulkanWindowContext BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 Committed: https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/viewer/sk_app/VulkanWindowContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
egdaniel
This does not fix the VK_TIMEOUT I was seeing which is a bug introduced in ...
4 years, 2 months ago (2016-09-26 18:55:30 UTC) #3
jvanverth1
lgtm How did it ever work?
4 years, 2 months ago (2016-09-26 19:18:17 UTC) #8
egdaniel
On 2016/09/26 19:18:17, jvanverth1 wrote: > lgtm > > How did it ever work? beats ...
4 years, 2 months ago (2016-09-26 19:19:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363353003/1
4 years, 2 months ago (2016-09-26 19:19:41 UTC) #11
jvanverth1
On 2016/09/26 19:18:17, jvanverth1 wrote: > lgtm > > How did it ever work? not ...
4 years, 2 months ago (2016-09-26 19:19:59 UTC) #12
jvanverth1
On 2016/09/26 19:19:59, jvanverth1 wrote: > On 2016/09/26 19:18:17, jvanverth1 wrote: > > lgtm > ...
4 years, 2 months ago (2016-09-26 19:20:34 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f
4 years, 2 months ago (2016-09-26 19:21:00 UTC) #16
egdaniel
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2370953002/ by egdaniel@google.com. ...
4 years, 2 months ago (2016-09-26 19:30:38 UTC) #17
jvanverth1
4 years, 2 months ago (2016-09-26 19:31:27 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2370963002/ by jvanverth@google.com.

The reason for reverting is: The bufferIndex check was correct, this is wrong..

Powered by Google App Engine
This is Rietveld 408576698