|
|
Created:
4 years, 2 months ago by egdaniel Modified:
4 years, 2 months ago Reviewers:
jvanverth1 CC:
reviews_skia.org Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionFix bufferIndex check in VulkanWindowContext
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003
Committed: https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Fix bufferIndex check in VulkanWindowContext BUG=skia: ========== to ========== Fix bufferIndex check in VulkanWindowContext BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 ==========
egdaniel@google.com changed reviewers: + jvanverth@google.com
This does not fix the VK_TIMEOUT I was seeing which is a bug introduced in the newest Adreno drivers it seems like.
The CQ bit was checked by egdaniel@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm How did it ever work?
On 2016/09/26 19:18:17, jvanverth1 wrote: > lgtm > > How did it ever work? beats me
The CQ bit was checked by egdaniel@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/26 19:18:17, jvanverth1 wrote: > lgtm > > How did it ever work? not lgtm
On 2016/09/26 19:19:59, jvanverth1 wrote: > On 2016/09/26 19:18:17, jvanverth1 wrote: > > lgtm > > > > How did it ever work? > > not lgtm There's one more backbuffer than images. See line 316.
The CQ bit was unchecked by jvanverth@google.com
Message was sent while issue was closed.
Description was changed from ========== Fix bufferIndex check in VulkanWindowContext BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 ========== to ========== Fix bufferIndex check in VulkanWindowContext BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 Committed: https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2370953002/ by egdaniel@google.com. The reason for reverting is: Fix not correct..
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2370963002/ by jvanverth@google.com. The reason for reverting is: The bufferIndex check was correct, this is wrong.. |