Chromium Code Reviews| Index: base/memory/memory_coordinator_client.h |
| diff --git a/base/memory/memory_coordinator_client.h b/base/memory/memory_coordinator_client.h |
| index da7104a8d94395decb299f15e86aa79069ce2e32..d0242ce15ff9eef39cf60df6480a7218db05e58e 100644 |
| --- a/base/memory/memory_coordinator_client.h |
| +++ b/base/memory/memory_coordinator_client.h |
| @@ -9,6 +9,14 @@ |
| namespace base { |
| +// OVERVIEW: |
| +// |
| +// MemoryCoordinatorClient is an interface which a component can implement to |
| +// respond to memory state changes. Unlike MemoryPressureListener, this is a |
| +// stateful mechanism and clients receive notifications only when memory states |
| +// are changed. State transitions are throttled to avoid thrashing; the exact |
| +// throttling period is platform dependent, but will be at least 5-10 seconds. |
| + |
| // MemoryState is an indicator that processes can use to guide their memory |
| // allocation policies. For example, a process that receives the suspended |
| // state can use that as as signal to drop memory caches. |
| @@ -24,12 +32,18 @@ enum class MemoryState { |
| }; |
| // This is an interface for components which can respond to memory status |
| -// changes. |
| +// changes. An initial state is NORMAL. See MemoryCoordinatorClientRegistry for |
|
dcheng
2016/09/26 06:01:49
Nit: An -> The
|
| +// threading guarantees and ownership management. |
| class BASE_EXPORT MemoryCoordinatorClient { |
| public: |
| virtual ~MemoryCoordinatorClient() {} |
| - // Called when memory state has changed. |
| + // Called when memory state has changed. Any transition could occur except for |
|
dcheng
2016/09/26 06:01:49
Nit: could => can
|
| + // UNKNOWN. General guidelines are: |
| + // * NORMAL: Restore the default settings for memory allocation/usage if |
| + // it has changed. |
| + // * THROTTLED: Use smaller limits for memory allocations and caches. |
| + // * SUSPENDED: Purge memory. |
| virtual void OnMemoryStateChange(MemoryState state) = 0; |
| }; |