Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1574)

Unified Diff: tools/perf/benchmarks/page_cycler_v2.py

Issue 2363343003: Add loading mobile story set (Closed)
Patch Set: wpr uploaded Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/benchmarks/page_cycler_v2.py
diff --git a/tools/perf/benchmarks/page_cycler_v2.py b/tools/perf/benchmarks/page_cycler_v2.py
index 2c3fa69e42333ed7785004c7c159f91b578694bb..3a1ce52356857d7735cabccaca15a1fe44b5c5eb 100644
--- a/tools/perf/benchmarks/page_cycler_v2.py
+++ b/tools/perf/benchmarks/page_cycler_v2.py
@@ -17,7 +17,7 @@ from telemetry.timeline import chrome_trace_category_filter
from telemetry.web_perf import timeline_based_measurement
-class _PageCyclerV2(perf_benchmark.PerfBenchmark):
+class PageCyclerV2(perf_benchmark.PerfBenchmark):
nednguyen 2016/09/30 09:46:56 You need to keep the name prefixed with "_", other
Kunihiko Sakamoto 2016/10/03 07:30:08 Done.
options = {'pageset_repeat': 2}
def CreateTimelineBasedMeasurementOptions(self):
@@ -64,7 +64,7 @@ class _PageCyclerV2(perf_benchmark.PerfBenchmark):
return False
-class PageCyclerV2Typical25(_PageCyclerV2):
+class PageCyclerV2Typical25(PageCyclerV2):
"""Page load time benchmark for a 25 typical web pages.
Designed to represent typical, not highly optimized or highly popular web
@@ -81,7 +81,7 @@ class PageCyclerV2Typical25(_PageCyclerV2):
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
-class PageCyclerV2IntlArFaHe(_PageCyclerV2):
+class PageCyclerV2IntlArFaHe(PageCyclerV2):
"""Page load time for a variety of pages in Arabic, Farsi and Hebrew.
Runs against pages recorded in April, 2013.
@@ -97,7 +97,7 @@ class PageCyclerV2IntlArFaHe(_PageCyclerV2):
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
-class PageCyclerV2IntlEsFrPtBr(_PageCyclerV2):
+class PageCyclerV2IntlEsFrPtBr(PageCyclerV2):
"""Page load time for a pages in Spanish, French and Brazilian Portuguese.
Runs against pages recorded in April, 2013.
@@ -113,7 +113,7 @@ class PageCyclerV2IntlEsFrPtBr(_PageCyclerV2):
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
-class PageCyclerV2IntlHiRu(_PageCyclerV2):
+class PageCyclerV2IntlHiRu(PageCyclerV2):
"""Page load time benchmark for a variety of pages in Hindi and Russian.
Runs against pages recorded in April, 2013.
@@ -129,7 +129,7 @@ class PageCyclerV2IntlHiRu(_PageCyclerV2):
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
-class PageCyclerV2IntlJaZh(_PageCyclerV2):
+class PageCyclerV2IntlJaZh(PageCyclerV2):
"""Page load time benchmark for a variety of pages in Japanese and Chinese.
Runs against pages recorded in April, 2013.
@@ -144,7 +144,7 @@ class PageCyclerV2IntlJaZh(_PageCyclerV2):
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
-class PageCyclerV2IntlKoThVi(_PageCyclerV2):
+class PageCyclerV2IntlKoThVi(PageCyclerV2):
"""Page load time for a variety of pages in Korean, Thai and Vietnamese.
Runs against pages recorded in April, 2013.
@@ -160,7 +160,7 @@ class PageCyclerV2IntlKoThVi(_PageCyclerV2):
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
-class PageCyclerV2Top10Mobile(_PageCyclerV2):
+class PageCyclerV2Top10Mobile(PageCyclerV2):
"""Page load time benchmark for the top 10 mobile web pages.
Runs against pages recorded in November, 2013.
@@ -176,7 +176,7 @@ class PageCyclerV2Top10Mobile(_PageCyclerV2):
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
-class PageCyclerV2ToughLayoutCases(_PageCyclerV2):
+class PageCyclerV2ToughLayoutCases(PageCyclerV2):
"""Page loading for the slowest layouts observed in the Alexa top 1 million.
Recorded in July 2013.
@@ -193,7 +193,7 @@ class PageCyclerV2ToughLayoutCases(_PageCyclerV2):
@benchmark.Disabled('reference', 'android')
-class PageCyclerV2BasicOopifIsolated(_PageCyclerV2):
+class PageCyclerV2BasicOopifIsolated(PageCyclerV2):
""" A benchmark measuring performance of out-of-process iframes. """
page_set = page_sets.OopifBasicPageSet
@@ -209,7 +209,7 @@ class PageCyclerV2BasicOopifIsolated(_PageCyclerV2):
cache_temperature.PCV1_COLD, cache_temperature.PCV1_WARM])
-class PageCyclerV2BasicOopif(_PageCyclerV2):
+class PageCyclerV2BasicOopif(PageCyclerV2):
""" A benchmark measuring performance of the out-of-process iframes page
set, without running in out-of-process iframes mode.. """
page_set = page_sets.OopifBasicPageSet

Powered by Google App Engine
This is Rietveld 408576698