[turbofan] Lower StringEqual and friends in EffectControlLinearizer.

[turbofan] Lower StringEqual and friends in EffectControlLinearizer.

Turn the StringEqualStub and friends into proper TurboFan builtins,
which means that we don't need to do on-demand compilation for those
stubs, and use those to defer lowering of the StringEqual, etc.
simplified operators to effect/control linearization (i.e. move it to
the concurrent recompilation part).

BUG=v8:5428
R=jarin@chromium.org

Committed: https://crrev.com/c176b26fee9dcfe9379a6e01b677298252a1602e
Cr-Commit-Position: refs/heads/master@{#39762}

[Benedikt Meurer, 2016-09-26 12:06:04]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 12:06:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jarin, 2016-09-26 12:21:23]

lgtm

https://codereview.chromium.org/2363333003/diff/1/src/builtins/builtins-strin...
File src/builtins/builtins-string.cc (right):

https://codereview.chromium.org/2363333003/diff/1/src/builtins/builtins-strin...
src/builtins/builtins-string.cc:60: Label if_lengthisequal(assembler),
if_lengthisnotequal(assembler);
What's up with the missing underscores?

https://codereview.chromium.org/2363333003/diff/1/src/compiler/effect-control...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2363333003/diff/1/src/compiler/effect-control...
src/compiler/effect-control-linearizer.cc:2621: Operator::kCommutative |
Operator::kEliminatable;
Nit: less-than is not commutative (actually, I do not even know what
commutativity means for calls).

[Benedikt Meurer, 2016-09-26 12:22:16]

https://codereview.chromium.org/2363333003/diff/1/src/compiler/effect-control...
File src/compiler/effect-control-linearizer.cc (right):

https://codereview.chromium.org/2363333003/diff/1/src/compiler/effect-control...
src/compiler/effect-control-linearizer.cc:2621: Operator::kCommutative |
Operator::kEliminatable;
On 2016/09/26 12:21:23, Jarin wrote:
> Nit: less-than is not commutative (actually, I do not even know what
> commutativity means for calls).

Done.

[Benedikt Meurer, 2016-09-26 12:22:19]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-09-26 12:22:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2363333003/#ps20001
(title: "Fix commutativity.")

[commit-bot: I haz the power, 2016-09-26 12:22:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 12:46:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 12:46:13]

Try jobs failed on following builders:
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/13454)
  v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)

[Benedikt Meurer, 2016-09-27 10:52:40]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[Benedikt Meurer, 2016-09-27 10:52:48]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2016-09-27 10:52:52]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-09-27 10:52:53]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org
Link to the patchset: https://codereview.chromium.org/2363333003/#ps40001
(title: "Preinitialize interface descriptors and drop TODO.")

[commit-bot: I haz the power, 2016-09-27 10:53:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 11:24:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 11:24:31]

Description was changed from

==========
[turbofan] Lower StringEqual and friends in EffectControlLinearizer.

Turn the StringEqualStub and friends into proper TurboFan builtins,
which means that we don't need to do on-demand compilation for those
stubs, and use those to defer lowering of the StringEqual, etc.
simplified operators to effect/control linearization (i.e. move it to
the concurrent recompilation part).

BUG=v8:5428
R=jarin@chromium.org
==========

to

==========
[turbofan] Lower StringEqual and friends in EffectControlLinearizer.

Turn the StringEqualStub and friends into proper TurboFan builtins,
which means that we don't need to do on-demand compilation for those
stubs, and use those to defer lowering of the StringEqual, etc.
simplified operators to effect/control linearization (i.e. move it to
the concurrent recompilation part).

BUG=v8:5428
R=jarin@chromium.org

Committed: https://crrev.com/c176b26fee9dcfe9379a6e01b677298252a1602e
Cr-Commit-Position: refs/heads/master@{#39762}
==========

[commit-bot: I haz the power, 2016-09-27 11:24:32]

Patchset 3 (id:??) landed as
https://crrev.com/c176b26fee9dcfe9379a6e01b677298252a1602e
Cr-Commit-Position: refs/heads/master@{#39762}