Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2363323003: Fix ContextUtils test flakiness. (Closed)

Created:
4 years, 2 months ago by Peter Wen
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ContextUtils test flakiness. There was a race condition between Android tests calling Application#onCreate and TestRunner#runTests which caused flakiness in some of the UrlManagerTest* and other instrumentation tests. Initialize the application object earlier so that it is always ready when tests are run. BUG=649224, 637448 Committed: https://crrev.com/640e90121d42acc469a533ae190e311841189827 Cr-Commit-Position: refs/heads/master@{#421256}

Patch Set 1 #

Patch Set 2 : Create application earlier for tests. #

Patch Set 3 : Remove debug log. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Peter Wen
Hi Ted, This moves initialization earlier and may help simplify the other CL I have ...
4 years, 2 months ago (2016-09-27 15:20:09 UTC) #6
Ted C
lgtm
4 years, 2 months ago (2016-09-27 17:09:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363323003/40001
4 years, 2 months ago (2016-09-27 17:40:31 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-27 17:46:24 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:48:34 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/640e90121d42acc469a533ae190e311841189827
Cr-Commit-Position: refs/heads/master@{#421256}

Powered by Google App Engine
This is Rietveld 408576698