Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2363313002: Offset repeating theads correctly when two tables adjoin at a page border (Closed)

Created:
4 years, 2 months ago by rhogan
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Offset repeating theads correctly when two tables adjoin at a page border When a header group is near a page border and doesn't fit on the page it may get a pagination strut to move it to the top of the next page. We need to subtract out that strut when storing the header's height for use later (when we paint the header across pages and have to move content rows below it). Also, when figuring out where the header starts on a series of pages we need to account for any strut it has so that we identify the place where the header group starts rather than just the table. BUG=634404 Review-Url: https://codereview.chromium.org/2219153002 Cr-Commit-Position: refs/heads/master@{#411747} (cherry picked from commit 581269dfb3c302163b973edcbbbf508291fe6671) Committed: https://chromium.googlesource.com/chromium/src/+/998d7a0d4ae2bacfb42f38b7c81a85ffad8c6f80

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
rhogan
4 years, 2 months ago (2016-09-25 18:44:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
998d7a0d4ae2bacfb42f38b7c81a85ffad8c6f80.

Powered by Google App Engine
This is Rietveld 408576698