media/filters/gpu_video_decoder.cc - Issue 2363303002: [WIP] Proxy RtcVideoDecoder calls to a media::VideoDecoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/gpu_video_decoder.cc

Issue 2363303002: [WIP] Proxy RtcVideoDecoder calls to a media::VideoDecoder.

Patch Set: Now working with remote ffmpeg decoder Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/gpu_video_decoder.cc

diff --git a/media/filters/gpu_video_decoder.cc b/media/filters/gpu_video_decoder.cc

index 671c25e9c96b6c2a45fa682ce0756be9e4037e6e..2901c6692b7b3179e1095977e910709b6cca3bde 100644

--- a/media/filters/gpu_video_decoder.cc

+++ b/media/filters/gpu_video_decoder.cc

@@ -589,6 +589,7 @@ void GpuVideoDecoder::PictureReady(const media::Picture& picture) {

if (!gfx::Rect(pb.size()).Contains(visible_rect)) {

LOG(WARNING) << "Visible size " << visible_rect.ToString()

<< " is larger than coded size " << pb.size().ToString();

+ NOTREACHED() << "NOTE(slan): This is a NotifyError in the WebRTC pipeline";

visible_rect = gfx::Rect(pb.size());

}