Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 236323002: Fixes to make possible to build snappy_unittest with gyp. (Closed)

Created:
6 years, 8 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Visibility:
Public.

Description

Fixes to make possible to build snappy_unittest with gyp. Currently it is not possible to build snappy_unittest target on Linux with the following command line: $ ninja -C out/Debug snappy_unittest This patch fixes this problem. BUG=None TEST=build snappy_unittest on Linux. R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267102

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -16 lines) Patch
A third_party/snappy/linux/config.h View 1 chunk +135 lines, -0 lines 0 comments Download
M third_party/snappy/snappy.gyp View 1 2 chunks +35 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jsbell
lgtm (sorry about the delay, I missed seeing this somehow)
6 years, 8 months ago (2014-04-24 20:55:50 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-04-29 03:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/236323002/1
6 years, 7 months ago (2014-04-29 03:50:46 UTC) #3
tfarina
On 2014/04/24 20:55:50, jsbell wrote: > lgtm > > (sorry about the delay, I missed ...
6 years, 7 months ago (2014-04-29 03:51:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 04:40:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 7 months ago (2014-04-29 04:40:38 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-04-30 01:41:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/236323002/20001
6 years, 7 months ago (2014-04-30 01:41:41 UTC) #8
tfarina
Joshua, I updated the gyp file to account for linux only for now and added ...
6 years, 7 months ago (2014-04-30 01:42:10 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 06:51:14 UTC) #10
Message was sent while issue was closed.
Change committed as 267102

Powered by Google App Engine
This is Rietveld 408576698