Use WithoutPathExpansion on DictionaryValue in GN.

Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config //:x.y --format=json

to produce something like

"//:x": {
  "y": {
    "args": [ ... ]
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.

Committed: https://crrev.com/d51d3527da33b8f736dda1e99bcd9dc1586b366f
Cr-Commit-Position: refs/heads/master@{#421005}

[bungeman-chromium, 2016-09-23 22:21:08]

Description was changed from

==========
Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config x.y --format=json

to produce something like

"x": {
  "y": {
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.
==========

to

==========
Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config x.y --format=json

to produce something like

"//:x": {
  "y": {
    "args": [ ... ]
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.
==========

[bungeman-chromium, 2016-09-23 22:21:27]

Description was changed from

==========
Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config x.y --format=json

to produce something like

"//:x": {
  "y": {
    "args": [ ... ]
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.
==========

to

==========
Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config //:x.y --format=json

to produce something like

"//:x": {
  "y": {
    "args": [ ... ]
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.
==========

[bungeman-chromium, 2016-09-23 22:25:31]

bungeman@chromium.org changed reviewers:
+ brettw@chromium.org

[bungeman-chromium, 2016-09-23 22:26:00]

https://codereview.chromium.org/2363193002/diff/1/tools/gn/json_project_write...
File tools/gn/json_project_writer.cc (left):

https://codereview.chromium.org/2363193002/diff/1/tools/gn/json_project_write...
tools/gn/json_project_writer.cc:104: std::move(description));
This 'Set' appears to be the one causing the issue described.

[bungeman-chromium, 2016-09-23 22:26:26]

The CQ bit was checked by bungeman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 22:27:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:45:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:45:47]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-09-26 21:12:52]

LGTM thanks!

[bungeman-chromium, 2016-09-26 21:31:46]

The CQ bit was checked by bungeman@chromium.org

[commit-bot: I haz the power, 2016-09-26 21:33:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 21:46:06]

Description was changed from

==========
Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config //:x.y --format=json

to produce something like

"//:x": {
  "y": {
    "args": [ ... ]
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.
==========

to

==========
Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config //:x.y --format=json

to produce something like

"//:x": {
  "y": {
    "args": [ ... ]
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.
==========

[commit-bot: I haz the power, 2016-09-26 21:46:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-26 21:47:56]

Description was changed from

==========
Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config //:x.y --format=json

to produce something like

"//:x": {
  "y": {
    "args": [ ... ]
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.
==========

to

==========
Use WithoutPathExpansion on DictionaryValue in GN.

The normal 'Set' methods on DictionaryValue scan for '.' in the path and
assume that the '.' indexes into an inner DictionaryValue. At no point
does gn appear to desire this behavior, so call the WithoutPathExpansion
variants instead.

This is mandatory when the path is user supplied, as it may have a '.'
This change was motivated by a target named like 'x.y' which caused

gn desc config //:x.y --format=json

to produce something like

"//:x": {
  "y": {
    "args": [ ... ]
    ...
  }
}

and similar issues when producing the project.json from the json ide
generator.

When the path is a constant which is known not to contain '.' there is
no behavioral change, but the extra work of scanning for the '.' is
avoided. In addition, if all uses are of the WithoutPathExpansion
variant then it becomes much less likely that similar errors will be
introduced in the future.

Committed: https://crrev.com/d51d3527da33b8f736dda1e99bcd9dc1586b366f
Cr-Commit-Position: refs/heads/master@{#421005}
==========

[commit-bot: I haz the power, 2016-09-26 21:47:57]

Patchset 1 (id:??) landed as
https://crrev.com/d51d3527da33b8f736dda1e99bcd9dc1586b366f
Cr-Commit-Position: refs/heads/master@{#421005}