Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_manager.h

Issue 2363183002: Skip installation process if WebAPK is already installed. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_manager.h
diff --git a/chrome/browser/android/webapps/add_to_homescreen_manager.h b/chrome/browser/android/webapps/add_to_homescreen_manager.h
index 6d87e1a794ed1b906122f8dea4e498ddfeb845cc..bc72a2af69514e728d3bbb0e8b2173b187f61fee 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_manager.h
+++ b/chrome/browser/android/webapps/add_to_homescreen_manager.h
@@ -56,7 +56,7 @@ class AddToHomescreenManager : public AddToHomescreenDataFetcher::Observer {
// Called only when the AddToHomescreenDataFetcher has retrieved all of the
// data needed to install a WebAPK.
- void CreateInfoBarForWebAPK(const ShortcutInfo& info, const SkBitmap& icon);
+ void CreateInfoBarForWebApk(const ShortcutInfo& info, const SkBitmap& icon);
void RecordAddToHomescreen();
@@ -71,11 +71,11 @@ class AddToHomescreenManager : public AddToHomescreenDataFetcher::Observer {
// Points to the Java object.
base::android::ScopedJavaGlobalRef<jobject> java_ref_;
pkotwicz 2016/09/29 14:18:54 Everyone has a slightly different commenting style
F 2016/09/30 18:02:02 Done.
- // Whether the user has requested that a shortcut be added while a fetch was
- // in progress.
+ // Indicates whether the user has requested that a shortcut be added while a
+ // fetch was in progress.
bool add_shortcut_pending_;
- // Whether the site is WebAPK-compatible.
+ // Indicates whether the site is WebAPK-compatible.
bool is_webapk_compatible_;
// Fetches data required to add a shortcut.

Powered by Google App Engine
This is Rietveld 408576698