Skip installation process if WebAPK is already installed.

chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/guid.h"
 #include "base/location.h"
@@ skipping 173 matching lines @@
     // Open the WebAPK.
     ScopedJavaLocalRef<jstring> java_webapk_package_name =
         base::android::ConvertUTF8ToJavaString(env, webapk_package_name_);
     Java_AppBannerInfoBarDelegateAndroid_openWebApk(env, java_delegate_,
                                                     java_webapk_package_name);
     webapk::TrackUserAction(webapk::USER_ACTION_INSTALLED_OPEN);
     SendBannerAccepted(web_contents, "web");
     return true;
   }
 
-  // Request install the WebAPK.
-  install_state_ = INSTALLING;
+  // Check whether the WebAPK has been installed.
+  std::string installed_webapk_package_name =
+      ShortcutHelper::QueryWebApkPackage(web_contents->GetLastCommittedURL());
+  if (installed_webapk_package_name.empty()) {
+    // Request install the WebAPK.
+    install_state_ = INSTALLING;
+    TrackUserResponse(USER_RESPONSE_WEB_APP_ACCEPTED);
+    webapk::TrackInstallSource(webapk_install_source_);
+    AppBannerSettingsHelper::RecordBannerInstallEvent(
+        web_contents, shortcut_info_->url.spec(), AppBannerSettingsHelper::WEB);
+
+    Java_AppBannerInfoBarDelegateAndroid_setWebApkInstallingState(
+        env, java_delegate_, true);
+    UpdateInstallState(env, nullptr);
+    WebApkInstaller::FinishCallback callback =
+        base::Bind(&AppBannerInfoBarDelegateAndroid::OnWebApkInstallFinished,
+                    weak_ptr_factory_.GetWeakPtr());
+    ShortcutHelper::InstallWebApkWithSkBitmap(web_contents->GetBrowserContext(),
+                                              *shortcut_info_,
+                                              *icon_.get(), callback);
+    SendBannerAccepted(web_contents, "web");
+
+    // Prevent the infobar from disappearing, because the infobar will show
+    // "Adding" during the installation process.
+    return false;
+  }
+
+  // Bypass the installation process.

[dominickn, 2016/09/30 23:32:24]

If you keep this comment, make it more explicit, like: "Bypass installation
since the WebAPK is already installed"

[F, 2016/10/03 14:13:44]

Done.

   TrackUserResponse(USER_RESPONSE_WEB_APP_ACCEPTED);
-  webapk::TrackInstallSource(webapk_install_source_);
-  AppBannerSettingsHelper::RecordBannerInstallEvent(
-      web_contents, shortcut_info_->url.spec(), AppBannerSettingsHelper::WEB);
-
-  Java_AppBannerInfoBarDelegateAndroid_setWebApkInstallingState(
-      env, java_delegate_, true);
-  UpdateInstallState(env, nullptr);
-  WebApkInstaller::FinishCallback callback =
-      base::Bind(&AppBannerInfoBarDelegateAndroid::OnWebApkInstallFinished,
-                  weak_ptr_factory_.GetWeakPtr());
-  ShortcutHelper::InstallWebApkWithSkBitmap(web_contents->GetBrowserContext(),
-                                            *shortcut_info_,
-                                            *icon_.get(), callback);
-  SendBannerAccepted(web_contents, "web");
-
-  // Prevent the infobar from disappearing, because the infobar will show
-  // "Adding" during the installation process.
+  weak_ptr_factory_.GetWeakPtr()->OnWebApkInstallFinished(

[dominickn, 2016/09/30 23:32:24]

Directly call OnWebApkInstallFinished(true, installed_webapk_package_name).
Going via the weak pointer is only necessary if you need to bind a callback to
be run later.

[F, 2016/10/03 14:13:44]

Done. Thanks!

+      true, installed_webapk_package_name);
   return false;
 }
 
 AppBannerInfoBarDelegateAndroid::AppBannerInfoBarDelegateAndroid(
     base::WeakPtr<AppBannerManager> weak_manager,
     const base::string16& app_title,
     std::unique_ptr<ShortcutInfo> shortcut_info,
     std::unique_ptr<SkBitmap> icon,
     int event_request_id,
     bool is_webapk,
@@ skipping 207 matching lines @@
 
   TrackDismissEvent(DISMISS_EVENT_BANNER_CLICK);
   return true;
 }
 
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env) {
  return RegisterNativesImpl(env);
 }
 
 }  // namespace banners