Skip installation process if WebAPK is already installed.

chrome/browser/android/webapps/add_to_homescreen_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapps/add_to_homescreen_manager.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/guid.h"
 #include "base/location.h"
@@ skipping 50 matching lines @@
   if (!user_title.empty())
     data_fetcher_->shortcut_info().user_title = user_title;
 
   if (data_fetcher_->is_ready()) {
     // If the fetcher isn't ready yet, the shortcut will be added when it is
     // via OnDataAvailable();
     AddShortcut(data_fetcher_->shortcut_info(), data_fetcher_->shortcut_icon());
   }
 }
 
 void AddToHomescreenManager::Start(content::WebContents* web_contents) {

[pkotwicz, 2016/09/29 14:18:54]

Thank you for making the changes in this file. They are good changes. However,
the changes are not related to the remainder of this change list. Can you move
them to a separate change list?

[F, 2016/09/30 18:02:02]

Done. Will do :)

-  bool check_installable = false;
+  // Check whether to check WebApk compatibility.
+  bool check_webapk_compatible = false;
   if (ChromeWebApkHost::AreWebApkEnabled() &&
       content::IsOriginSecure(web_contents->GetLastCommittedURL())) {
-    check_installable = true;
+    check_webapk_compatible = true;
   } else {
     ShowDialog();
   }
 
   data_fetcher_ = new AddToHomescreenDataFetcher(
       web_contents, ShortcutHelper::GetIdealHomescreenIconSizeInDp(),
       ShortcutHelper::GetMinimumHomescreenIconSizeInDp(),
       ShortcutHelper::GetIdealSplashImageSizeInDp(),
       ShortcutHelper::GetMinimumSplashImageSizeInDp(),
-      check_installable, this);
+      check_webapk_compatible, this);
 }
 
 AddToHomescreenManager::~AddToHomescreenManager() {
   if (data_fetcher_) {
     data_fetcher_->set_weak_observer(nullptr);
     data_fetcher_ = nullptr;
   }
 }
 
 void AddToHomescreenManager::ShowDialog() {
@@ skipping 49 matching lines @@
   ScopedJavaLocalRef<jstring> j_user_title =
       base::android::ConvertUTF16ToJavaString(env, user_title);
   Java_AddToHomescreenManager_onUserTitleAvailable(env,
                                                    java_ref_,
                                                    j_user_title);
 }
 
 void AddToHomescreenManager::OnDataAvailable(const ShortcutInfo& info,
                                              const SkBitmap& icon) {
   if (is_webapk_compatible_) {
-    CreateInfoBarForWebAPK(info, icon);
+    CreateInfoBarForWebApk(info, icon);
     return;
   }
 
   JNIEnv* env = base::android::AttachCurrentThread();
   ScopedJavaLocalRef<jobject> java_bitmap;
   if (icon.getSize())
     java_bitmap = gfx::ConvertToJavaBitmap(&icon);
 
   Java_AddToHomescreenManager_onReadyToAdd(env, java_ref_, java_bitmap);
 
   if (add_shortcut_pending_)
     AddShortcut(info, icon);
 }
 
-void AddToHomescreenManager::CreateInfoBarForWebAPK(const ShortcutInfo& info,
+void AddToHomescreenManager::CreateInfoBarForWebApk(const ShortcutInfo& info,
                                                     const SkBitmap& icon) {
   banners::AppBannerInfoBarDelegateAndroid::Create(
       data_fetcher_->web_contents(), nullptr, info.user_title,
       base::MakeUnique<ShortcutInfo>(info), base::MakeUnique<SkBitmap>(icon),
       -1 /* event_request_id */, true /* is_webapk */,
       true /* start_install_webapk */);
 }
 
 SkBitmap AddToHomescreenManager::FinalizeLauncherIconInBackground(
     const SkBitmap& bitmap,
     const GURL& url,
     bool* is_generated) {
   DCHECK(content::BrowserThread::GetBlockingPool()->RunsTasksOnCurrentThread());
 
   return ShortcutHelper::FinalizeLauncherIconInBackground(bitmap, url,
                                                           is_generated);
 }