Migrate Linux Blimp client to use BlimpClientContext

blimp/client/app/linux/blimp_client_context_delegate_linux.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/ptr_util.h"
+#include "blimp/client/app/linux/blimp_client_context_delegate_linux.h"
+#include "blimp/client/support/session/blimp_default_identity_provider.h"
+
+namespace blimp {
+namespace client {
+
+BlimpClientContextDelegateLinux::BlimpClientContextDelegateLinux() = default;
+
+BlimpClientContextDelegateLinux::~BlimpClientContextDelegateLinux() = default;
+
+void BlimpClientContextDelegateLinux::AttachBlimpContentsHelpers(
+    BlimpContents* blimp_contents) {}
+
+void BlimpClientContextDelegateLinux::OnAssignmentConnectionAttempted(
+    AssignmentRequestResult result,
+    const Assignment& assignment) {
+  switch (result) {
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_OK:
+      VLOG(0) << "Assignment request success";
+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_UNKNOWN:
+      LOG(WARNING) << "Assignment request result unknown";
+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_BAD_REQUEST:
+      LOG(WARNING) << "Assignment request error: Bad request";

[Kevin M, 2016/09/28 01:35:46]

Recommend adding this code to string table to the Assignment library. So you'd
have

const char* AssignmentRequestResultToString(result) {
  switch {
    case BLAHBLAH_UNKNOWN:
      return "UNKNOWN";
    case BLAHBLAH_EXPIRED_ACCESS_TOKEN:
      return "EXPIRED_ACCESS_TOKEN";
    ...
  }
}

Then you would just call that function here:

LOG(WARNING) << "Assignment request error: " <<
AssignmentRequestResultToString(result);

and remove the switch case from this function.

[David Trainor- moved to gerrit, 2016/09/28 16:34:01]

This is happening at a slightly higher level in xingliu@'s CL, where we need to
clean up the strings to be presented to the user.  It won't be this exact error
code but it'll be a user-friendly version of it.  We could use that instead if
it makes more sense.

[steimel, 2016/09/28 20:33:07]

Added TODO for xingliu@ to update to use new error strings.

+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_BAD_RESPONSE:
+      LOG(WARNING) << "Assignment request error: Bad response";
+      break;
+    case AssignmentRequestResult::
+        ASSIGNMENT_REQUEST_RESULT_INVALID_PROTOCOL_VERSION:
+      LOG(WARNING) << "Assignment request error: Invalid protocol version";
+      break;
+    case AssignmentRequestResult::
+        ASSIGNMENT_REQUEST_RESULT_EXPIRED_ACCESS_TOKEN:
+      LOG(WARNING) << "Assignment request error: Expired access token";
+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_USER_INVALID:
+      LOG(WARNING) << "Assignment request error: User invalid";
+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_OUT_OF_VMS:
+      LOG(WARNING) << "Assignment request error: Out of VMs";
+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_SERVER_ERROR:
+      LOG(WARNING) << "Assignment request error: Server error";
+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_SERVER_INTERRUPTED:
+      LOG(WARNING) << "Assignment request error: Server interrupted";
+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_NETWORK_FAILURE:
+      LOG(WARNING) << "Assignment request error: Network failure";
+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_INVALID_CERT:
+      LOG(WARNING) << "Assignment request error: Invalid cert";
+      break;
+  }
+}
+
+std::unique_ptr<IdentityProvider>
+BlimpClientContextDelegateLinux::CreateIdentityProvider() {
+  return base::MakeUnique<BlimpDefaultIdentityProvider>();
+}
+
+void BlimpClientContextDelegateLinux::OnAuthenticationError(
+    BlimpClientContextDelegate::AuthError error) {
+  switch (error) {
+    case BlimpClientContextDelegate::AuthError::NOT_SIGNED_IN:
+      LOG(WARNING) << "Error: Not signed in";
+      break;
+    case BlimpClientContextDelegate::AuthError::OAUTH_TOKEN_FAIL:
+      LOG(WARNING) << "Error: OAuth token failure";
+      break;
+  }
+}
+
+}  // namespace client
+}  // namespace blimp