Migrate Linux Blimp client to use BlimpClientContext

blimp/client/app/linux/blimp_client_context_delegate_linux.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/memory/ptr_util.h"
+#include "blimp/client/app/linux/blimp_client_context_delegate_linux.h"
+#include "blimp/client/support/session/blimp_default_identity_provider.h"
+
+namespace blimp {
+namespace client {
+
+BlimpClientContextDelegateLinux::BlimpClientContextDelegateLinux() = default;
+
+BlimpClientContextDelegateLinux::~BlimpClientContextDelegateLinux() = default;
+
+void BlimpClientContextDelegateLinux::AttachBlimpContentsHelpers(
+    BlimpContents* blimp_contents) {}
+
+void BlimpClientContextDelegateLinux::OnAssignmentConnectionAttempted(
+    AssignmentRequestResult result,
+    const Assignment& assignment) {
+  switch (result) {
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_UNKNOWN:
+      VLOG(0) << "Assignment connection attempt result unknown";

[Kevin M, 2016/09/27 21:59:40]

These should probably be LOG(INFO|ERROR) or DLOG(), not VLOG, so that users
don't have to explicitly opt-in to seeing these (important) logging lines.

[Kevin M, 2016/09/27 21:59:41]

"Connection" isn't a good term here and elsewhere. Assignments can fail for
reasons other than connections.

[steimel, 2016/09/27 23:23:19]

Done.

+      break;
+    case AssignmentRequestResult::ASSIGNMENT_REQUEST_RESULT_OK:

[Kevin M, 2016/09/27 21:59:40]

Move success case to the top.

[steimel, 2016/09/27 23:23:19]

Done.

+      VLOG(0) << "Assignment connection success";
+      break;
+    default:

[Kevin M, 2016/09/27 21:59:40]

Don't use "default" if you can avoid it - this lets the static enum coverage
checks do their thing.

[steimel, 2016/09/27 23:23:19]

Done.

+      VLOG(0) << "Assignment connection error: " << result;
+      break;
+  }
+}
+
+std::unique_ptr<IdentityProvider>
+BlimpClientContextDelegateLinux::CreateIdentityProvider() {
+  return base::MakeUnique<BlimpDefaultIdentityProvider>();
+}
+
+void BlimpClientContextDelegateLinux::OnAuthenticationError(
+    BlimpClientContextDelegate::AuthError error) {
+  switch (error) {
+    case BlimpClientContextDelegate::AuthError::NOT_SIGNED_IN:
+      VLOG(0) << "Error: Not signed in";

[Kevin M, 2016/09/27 21:59:41]

LOG(ERROR)

[steimel, 2016/09/27 23:23:19]

Done.

+      break;
+    case BlimpClientContextDelegate::AuthError::OAUTH_TOKEN_FAIL:
+      VLOG(0) << "Error: OAuth token failure";
+      break;
+  }
+}
+
+}  // namespace client
+}  // namespace blimp