Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 236313015: Handlify and convert the remaining Script accesssors. (Closed)

Created:
6 years, 8 months ago by ulan
Modified:
6 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Handlify and convert the remaining Script accesssors. BUG= R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20814

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -160 lines) Patch
M src/accessors.h View 2 chunks +8 lines, -27 lines 0 comments Download
M src/accessors.cc View 8 chunks +205 lines, -90 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +28 lines, -43 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 8 months ago (2014-04-16 14:08:57 UTC) #1
Yang
On 2014/04/16 14:08:57, ulan wrote: > PTAL lgtm.
6 years, 8 months ago (2014-04-16 14:11:17 UTC) #2
ulan
6 years, 8 months ago (2014-04-16 14:31:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698