Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: tests/compiler/dart2js/mirrors_used_test.dart

Issue 236313012: Don't hide interceptors in mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/lib/js_rti.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/mirrors_used_test.dart
diff --git a/tests/compiler/dart2js/mirrors_used_test.dart b/tests/compiler/dart2js/mirrors_used_test.dart
index dda883401c200b797ee20fa0d348a71e0ad1949c..ba2afed7e759516e56d85826359a607bb56d076a 100644
--- a/tests/compiler/dart2js/mirrors_used_test.dart
+++ b/tests/compiler/dart2js/mirrors_used_test.dart
@@ -74,6 +74,18 @@ void main() {
[
'Foo_staticMethod', // The name of Foo.staticMethod.
r'instanceMethod$0']; // The name of Foo.instanceMethod.
+
+ // We always include the names of some native classes.
+ List<Element> nativeClasses = [
+ compiler.intClass, compiler.doubleClass, compiler.numClass,
+ compiler.stringClass, compiler.boolClass, compiler.nullClass,
+ compiler.listClass
+ ];
+
+ Iterable<String> nativeNames =
+ nativeClasses.map(compiler.backend.namer.getNameOfClass);
+ expectedNames.addAll(nativeNames);
+
Set recordedNames = new Set()
..addAll(compiler.backend.emitter.recordedMangledNames)
..addAll(compiler.backend.emitter.mangledFieldNames.keys)
« no previous file with comments | « sdk/lib/_internal/lib/js_rti.dart ('k') | tests/compiler/dart2js/mock_compiler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698