Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

Issue 236313012: Don't hide interceptors in mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
index 76d0b4068d94bb6063cfbb2ac660fda0060c9171..55a374b50dec775d4a2e37b5815d1ca037af6334 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart
@@ -45,15 +45,6 @@ class RuntimeTypes {
Set<ClassElement> allInstantiatedArguments;
Set<ClassElement> checkedArguments;
- bool isJsNative(Element element) {
- return (element == compiler.intClass ||
- element == compiler.boolClass ||
- element == compiler.numClass ||
- element == compiler.doubleClass ||
- element == compiler.stringClass ||
- element == compiler.listClass);
- }
-
void registerRtiDependency(Element element, Element dependency) {
// We're not dealing with typedef for now.
if (!element.isClass() || !dependency.isClass()) return;
@@ -635,7 +626,7 @@ class TypeRepresentationGenerator extends DartTypeVisitor {
}
jsAst.Expression getJavaScriptClassName(Element element) {
- return namer.elementAccess(backend.getImplementationClass(element));
+ return namer.elementAccess(element);
}
visit(DartType type) {
@@ -782,9 +773,7 @@ class ArgumentCollector extends DartTypeVisitor {
}
visitInterfaceType(InterfaceType type, bool isTypeArgument) {
- if (isTypeArgument) {
- classes.add(backend.getImplementationClass(type.element));
- }
+ if (isTypeArgument) classes.add(type.element);
type.visitChildren(this, true);
}
@@ -825,7 +814,7 @@ class FunctionArgumentCollector extends DartTypeVisitor {
visitInterfaceType(InterfaceType type, bool inFunctionType) {
if (inFunctionType) {
- classes.add(backend.getImplementationClass(type.element));
+ classes.add(type.element);
}
type.visitChildren(this, inFunctionType);
}

Powered by Google App Engine
This is Rietveld 408576698