Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2363123002: Revert of [fullcodegen] Refactor code that calls store ICs. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/x64/full-codegen-x64.cc
diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc
index b0042c5a0110201a2976ea4543f693bc4d40dbb8..50a5af56d1ad4dfb765ad5b114e11fa4bb95de33 100644
--- a/src/full-codegen/x64/full-codegen-x64.cc
+++ b/src/full-codegen/x64/full-codegen-x64.cc
@@ -1119,9 +1119,12 @@
FeedbackVectorSlot slot) {
DCHECK(NeedsHomeObject(initializer));
__ movp(StoreDescriptor::ReceiverRegister(), Operand(rsp, 0));
+ __ Move(StoreDescriptor::NameRegister(),
+ isolate()->factory()->home_object_symbol());
__ movp(StoreDescriptor::ValueRegister(),
Operand(rsp, offset * kPointerSize));
- CallStoreIC(slot, isolate()->factory()->home_object_symbol());
+ EmitLoadStoreICSlot(slot);
+ CallStoreIC();
}
@@ -1130,9 +1133,12 @@
FeedbackVectorSlot slot) {
DCHECK(NeedsHomeObject(initializer));
__ movp(StoreDescriptor::ReceiverRegister(), rax);
+ __ Move(StoreDescriptor::NameRegister(),
+ isolate()->factory()->home_object_symbol());
__ movp(StoreDescriptor::ValueRegister(),
Operand(rsp, offset * kPointerSize));
- CallStoreIC(slot, isolate()->factory()->home_object_symbol());
+ EmitLoadStoreICSlot(slot);
+ CallStoreIC();
}
@@ -1367,8 +1373,10 @@
if (property->emit_store()) {
VisitForAccumulatorValue(value);
DCHECK(StoreDescriptor::ValueRegister().is(rax));
+ __ Move(StoreDescriptor::NameRegister(), key->value());
__ movp(StoreDescriptor::ReceiverRegister(), Operand(rsp, 0));
- CallStoreIC(property->GetSlot(0), key->value());
+ EmitLoadStoreICSlot(property->GetSlot(0));
+ CallStoreIC();
PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
if (NeedsHomeObject(value)) {
@@ -1557,7 +1565,8 @@
__ Move(StoreDescriptor::NameRegister(), Smi::FromInt(array_index));
__ movp(StoreDescriptor::ReceiverRegister(), Operand(rsp, 0));
- CallKeyedStoreIC(expr->LiteralFeedbackSlot());
+ EmitLoadStoreICSlot(expr->LiteralFeedbackSlot());
+ CallKeyedStoreIC();
PrepareForBailoutForId(expr->GetIdForElement(array_index),
BailoutState::NO_REGISTERS);
@@ -1945,7 +1954,10 @@
VisitForAccumulatorValue(prop->obj());
__ Move(StoreDescriptor::ReceiverRegister(), rax);
PopOperand(StoreDescriptor::ValueRegister()); // Restore value.
- CallStoreIC(slot, prop->key()->AsLiteral()->value());
+ __ Move(StoreDescriptor::NameRegister(),
+ prop->key()->AsLiteral()->value());
+ EmitLoadStoreICSlot(slot);
+ CallStoreIC();
break;
}
case NAMED_SUPER_PROPERTY: {
@@ -1992,7 +2004,8 @@
__ Move(StoreDescriptor::NameRegister(), rax);
PopOperand(StoreDescriptor::ReceiverRegister());
PopOperand(StoreDescriptor::ValueRegister()); // Restore value.
- CallKeyedStoreIC(slot);
+ EmitLoadStoreICSlot(slot);
+ CallKeyedStoreIC();
break;
}
}
@@ -2015,8 +2028,10 @@
FeedbackVectorSlot slot) {
if (var->IsUnallocated()) {
// Global var, const, or let.
+ __ Move(StoreDescriptor::NameRegister(), var->name());
__ LoadGlobalObject(StoreDescriptor::ReceiverRegister());
- CallStoreIC(slot, var->name());
+ EmitLoadStoreICSlot(slot);
+ CallStoreIC();
} else if (IsLexicalVariableMode(var->mode()) && op != Token::INIT) {
DCHECK(!var->IsLookupSlot());
@@ -2083,8 +2098,10 @@
DCHECK(prop != NULL);
DCHECK(prop->key()->IsLiteral());
+ __ Move(StoreDescriptor::NameRegister(), prop->key()->AsLiteral()->value());
PopOperand(StoreDescriptor::ReceiverRegister());
- CallStoreIC(expr->AssignmentSlot(), prop->key()->AsLiteral()->value());
+ EmitLoadStoreICSlot(expr->AssignmentSlot());
+ CallStoreIC();
PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);
context()->Plug(rax);
@@ -2125,7 +2142,8 @@
PopOperand(StoreDescriptor::NameRegister()); // Key.
PopOperand(StoreDescriptor::ReceiverRegister());
DCHECK(StoreDescriptor::ValueRegister().is(rax));
- CallKeyedStoreIC(expr->AssignmentSlot());
+ EmitLoadStoreICSlot(expr->AssignmentSlot());
+ CallKeyedStoreIC();
PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);
context()->Plug(rax);
@@ -3173,8 +3191,11 @@
}
break;
case NAMED_PROPERTY: {
+ __ Move(StoreDescriptor::NameRegister(),
+ prop->key()->AsLiteral()->value());
PopOperand(StoreDescriptor::ReceiverRegister());
- CallStoreIC(expr->CountSlot(), prop->key()->AsLiteral()->value());
+ EmitLoadStoreICSlot(expr->CountSlot());
+ CallStoreIC();
PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);
if (expr->is_postfix()) {
if (!context()->IsEffect()) {
@@ -3212,7 +3233,8 @@
case KEYED_PROPERTY: {
PopOperand(StoreDescriptor::NameRegister());
PopOperand(StoreDescriptor::ReceiverRegister());
- CallKeyedStoreIC(expr->CountSlot());
+ EmitLoadStoreICSlot(expr->CountSlot());
+ CallKeyedStoreIC();
PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);
if (expr->is_postfix()) {
if (!context()->IsEffect()) {
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698