Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2363123002: Revert of [fullcodegen] Refactor code that calls store ICs. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/arm/full-codegen-arm.cc
diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc
index 644938eea1c5cdd0f32a4245e7763ced7287c009..9ca85c607b6bfd09bdb2bb13ad07588cf0b67d7f 100644
--- a/src/full-codegen/arm/full-codegen-arm.cc
+++ b/src/full-codegen/arm/full-codegen-arm.cc
@@ -1168,9 +1168,12 @@
FeedbackVectorSlot slot) {
DCHECK(NeedsHomeObject(initializer));
__ ldr(StoreDescriptor::ReceiverRegister(), MemOperand(sp));
+ __ mov(StoreDescriptor::NameRegister(),
+ Operand(isolate()->factory()->home_object_symbol()));
__ ldr(StoreDescriptor::ValueRegister(),
MemOperand(sp, offset * kPointerSize));
- CallStoreIC(slot, isolate()->factory()->home_object_symbol());
+ EmitLoadStoreICSlot(slot);
+ CallStoreIC();
}
@@ -1179,9 +1182,12 @@
FeedbackVectorSlot slot) {
DCHECK(NeedsHomeObject(initializer));
__ Move(StoreDescriptor::ReceiverRegister(), r0);
+ __ mov(StoreDescriptor::NameRegister(),
+ Operand(isolate()->factory()->home_object_symbol()));
__ ldr(StoreDescriptor::ValueRegister(),
MemOperand(sp, offset * kPointerSize));
- CallStoreIC(slot, isolate()->factory()->home_object_symbol());
+ EmitLoadStoreICSlot(slot);
+ CallStoreIC();
}
@@ -1416,8 +1422,10 @@
if (property->emit_store()) {
VisitForAccumulatorValue(value);
DCHECK(StoreDescriptor::ValueRegister().is(r0));
+ __ mov(StoreDescriptor::NameRegister(), Operand(key->value()));
__ ldr(StoreDescriptor::ReceiverRegister(), MemOperand(sp));
- CallStoreIC(property->GetSlot(0), key->value());
+ EmitLoadStoreICSlot(property->GetSlot(0));
+ CallStoreIC();
PrepareForBailoutForId(key->id(), BailoutState::NO_REGISTERS);
if (NeedsHomeObject(value)) {
@@ -1615,7 +1623,8 @@
__ mov(StoreDescriptor::NameRegister(), Operand(Smi::FromInt(array_index)));
__ ldr(StoreDescriptor::ReceiverRegister(), MemOperand(sp, 0));
- CallKeyedStoreIC(expr->LiteralFeedbackSlot());
+ EmitLoadStoreICSlot(expr->LiteralFeedbackSlot());
+ CallKeyedStoreIC();
PrepareForBailoutForId(expr->GetIdForElement(array_index),
BailoutState::NO_REGISTERS);
@@ -2047,7 +2056,10 @@
VisitForAccumulatorValue(prop->obj());
__ Move(StoreDescriptor::ReceiverRegister(), r0);
PopOperand(StoreDescriptor::ValueRegister()); // Restore value.
- CallStoreIC(slot, prop->key()->AsLiteral()->value());
+ __ mov(StoreDescriptor::NameRegister(),
+ Operand(prop->key()->AsLiteral()->value()));
+ EmitLoadStoreICSlot(slot);
+ CallStoreIC();
break;
}
case NAMED_SUPER_PROPERTY: {
@@ -2094,7 +2106,8 @@
__ Move(StoreDescriptor::NameRegister(), r0);
PopOperands(StoreDescriptor::ValueRegister(),
StoreDescriptor::ReceiverRegister());
- CallKeyedStoreIC(slot);
+ EmitLoadStoreICSlot(slot);
+ CallKeyedStoreIC();
break;
}
}
@@ -2119,8 +2132,10 @@
FeedbackVectorSlot slot) {
if (var->IsUnallocated()) {
// Global var, const, or let.
+ __ mov(StoreDescriptor::NameRegister(), Operand(var->name()));
__ LoadGlobalObject(StoreDescriptor::ReceiverRegister());
- CallStoreIC(slot, var->name());
+ EmitLoadStoreICSlot(slot);
+ CallStoreIC();
} else if (IsLexicalVariableMode(var->mode()) && op != Token::INIT) {
DCHECK(!var->IsLookupSlot());
@@ -2188,8 +2203,11 @@
DCHECK(prop != NULL);
DCHECK(prop->key()->IsLiteral());
+ __ mov(StoreDescriptor::NameRegister(),
+ Operand(prop->key()->AsLiteral()->value()));
PopOperand(StoreDescriptor::ReceiverRegister());
- CallStoreIC(expr->AssignmentSlot(), prop->key()->AsLiteral()->value());
+ EmitLoadStoreICSlot(expr->AssignmentSlot());
+ CallStoreIC();
PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);
context()->Plug(r0);
@@ -2231,7 +2249,8 @@
StoreDescriptor::NameRegister());
DCHECK(StoreDescriptor::ValueRegister().is(r0));
- CallKeyedStoreIC(expr->AssignmentSlot());
+ EmitLoadStoreICSlot(expr->AssignmentSlot());
+ CallKeyedStoreIC();
PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);
context()->Plug(r0);
@@ -3285,8 +3304,11 @@
}
break;
case NAMED_PROPERTY: {
+ __ mov(StoreDescriptor::NameRegister(),
+ Operand(prop->key()->AsLiteral()->value()));
PopOperand(StoreDescriptor::ReceiverRegister());
- CallStoreIC(expr->CountSlot(), prop->key()->AsLiteral()->value());
+ EmitLoadStoreICSlot(expr->CountSlot());
+ CallStoreIC();
PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);
if (expr->is_postfix()) {
if (!context()->IsEffect()) {
@@ -3324,7 +3346,8 @@
case KEYED_PROPERTY: {
PopOperands(StoreDescriptor::ReceiverRegister(),
StoreDescriptor::NameRegister());
- CallKeyedStoreIC(expr->CountSlot());
+ EmitLoadStoreICSlot(expr->CountSlot());
+ CallKeyedStoreIC();
PrepareForBailoutForId(expr->AssignmentId(), BailoutState::TOS_REGISTER);
if (expr->is_postfix()) {
if (!context()->IsEffect()) {
« no previous file with comments | « no previous file | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698