Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: src/full-codegen/full-codegen.h

Issue 2363123002: Revert of [fullcodegen] Refactor code that calls store ICs. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FULL_CODEGEN_FULL_CODEGEN_H_ 5 #ifndef V8_FULL_CODEGEN_FULL_CODEGEN_H_
6 #define V8_FULL_CODEGEN_FULL_CODEGEN_H_ 6 #define V8_FULL_CODEGEN_FULL_CODEGEN_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/assert-scope.h" 9 #include "src/assert-scope.h"
10 #include "src/ast/ast.h" 10 #include "src/ast/ast.h"
(...skipping 595 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 606
607 // Adds the [[HomeObject]] to |initializer| if it is a FunctionLiteral. 607 // Adds the [[HomeObject]] to |initializer| if it is a FunctionLiteral.
608 // The value of the initializer is expected to be at the top of the stack. 608 // The value of the initializer is expected to be at the top of the stack.
609 // |offset| is the offset in the stack where the home object can be found. 609 // |offset| is the offset in the stack where the home object can be found.
610 void EmitSetHomeObject(Expression* initializer, int offset, 610 void EmitSetHomeObject(Expression* initializer, int offset,
611 FeedbackVectorSlot slot); 611 FeedbackVectorSlot slot);
612 612
613 void EmitSetHomeObjectAccumulator(Expression* initializer, int offset, 613 void EmitSetHomeObjectAccumulator(Expression* initializer, int offset,
614 FeedbackVectorSlot slot); 614 FeedbackVectorSlot slot);
615 615
616 // Platform-specific code for loading a slot to a register. 616 void EmitLoadStoreICSlot(FeedbackVectorSlot slot);
617 void EmitLoadSlot(Register destination, FeedbackVectorSlot slot);
618 // Platform-specific code for pushing a slot to the stack.
619 void EmitPushSlot(FeedbackVectorSlot slot);
620 617
621 void CallIC(Handle<Code> code, 618 void CallIC(Handle<Code> code,
622 TypeFeedbackId id = TypeFeedbackId::None()); 619 TypeFeedbackId id = TypeFeedbackId::None());
623 620
624 void CallLoadIC(TypeFeedbackId id = TypeFeedbackId::None()); 621 void CallLoadIC(TypeFeedbackId id = TypeFeedbackId::None());
625 // Inside typeof reference errors are never thrown. 622 // Inside typeof reference errors are never thrown.
626 void CallLoadGlobalIC(TypeofMode typeof_mode, 623 void CallLoadGlobalIC(TypeofMode typeof_mode,
627 TypeFeedbackId id = TypeFeedbackId::None()); 624 TypeFeedbackId id = TypeFeedbackId::None());
628 void CallStoreIC(FeedbackVectorSlot slot, Handle<Object> name, 625 void CallStoreIC(TypeFeedbackId id = TypeFeedbackId::None());
629 TypeFeedbackId id = TypeFeedbackId::None()); 626 void CallKeyedStoreIC();
630 void CallKeyedStoreIC(FeedbackVectorSlot slot);
631 627
632 void SetFunctionPosition(FunctionLiteral* fun); 628 void SetFunctionPosition(FunctionLiteral* fun);
633 void SetReturnPosition(FunctionLiteral* fun); 629 void SetReturnPosition(FunctionLiteral* fun);
634 630
635 enum InsertBreak { INSERT_BREAK, SKIP_BREAK }; 631 enum InsertBreak { INSERT_BREAK, SKIP_BREAK };
636 632
637 // During stepping we want to be able to break at each statement, but not at 633 // During stepping we want to be able to break at each statement, but not at
638 // every (sub-)expression. That is why by default we insert breaks at every 634 // every (sub-)expression. That is why by default we insert breaks at every
639 // statement position, but not at every expression position, unless stated 635 // statement position, but not at every expression position, unless stated
640 // otherwise. 636 // otherwise.
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
1027 Address start_; 1023 Address start_;
1028 Address instruction_start_; 1024 Address instruction_start_;
1029 uint32_t length_; 1025 uint32_t length_;
1030 }; 1026 };
1031 1027
1032 1028
1033 } // namespace internal 1029 } // namespace internal
1034 } // namespace v8 1030 } // namespace v8
1035 1031
1036 #endif // V8_FULL_CODEGEN_FULL_CODEGEN_H_ 1032 #endif // V8_FULL_CODEGEN_FULL_CODEGEN_H_
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698