content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java - Issue 2363113003: Lint suppressions needed for Android SDK roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

Issue 2363113003: Lint suppressions needed for Android SDK roll. (Closed)

Patch Set: Suppress alert box presubmit. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java ('k') | content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

index 5aba4acc080ccb40c8f940f05ea3defb9d321c6b..9926e670452081013d3aafb4e2d9d36c12f73957 100644

--- a/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

+++ b/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java

@@ -4,6 +4,7 @@

package org.chromium.content.browser.input;

+import android.annotation.SuppressLint;

import android.os.Bundle;

import android.os.Handler;

import android.os.Looper;

@@ -678,6 +679,8 @@ public class ThreadedInputConnection extends BaseInputConnection

/**

* @see InputConnection#closeConnection()

+ // TODO(crbug.com/635567): Fix this properly.

+ @SuppressLint("MissingSuperCall")

public void closeConnection() {

if (DEBUG_LOGS) Log.w(TAG, "closeConnection");

// TODO(changwan): Implement this. http://crbug.com/595525