chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java - Issue 2363113003: Lint suppressions needed for Android SDK roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java

Issue 2363113003: Lint suppressions needed for Android SDK roll. (Closed)

Patch Set: Suppress alert box presubmit. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java ('k') | content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java

diff --git a/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java b/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java

index 143c043e5c6b5883c0e84b844e0bc3215e888e52..97938df558441d31183faae330f970c33b001be3 100644

--- a/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java

+++ b/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/DexOptimizer.java

@@ -4,6 +4,7 @@

package org.chromium.webapk.lib.client;

+import android.annotation.SuppressLint;

import android.os.Build;

import android.util.Log;

@@ -30,6 +31,8 @@ public class DexOptimizer {

* @param dexFile Path to a dex file.

* @return True if the dex file was successfully optimized.

+ // TODO(crbug.com/635567): Fix this properly.

+ @SuppressLint("SetWorldReadable")

public static boolean optimize(File dexFile) {

if (!dexFile.exists()) {

Log.e(TAG, "Dex file does not exist! " + dexFile.getAbsolutePath());