chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java - Issue 2363113003: Lint suppressions needed for Android SDK roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java

Issue 2363113003: Lint suppressions needed for Android SDK roll. (Closed)

Patch Set: Suppress alert box presubmit. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionStatsPreference.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java b/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java

index c902e2e0439f02e0ff4e859e4160721b9ca2e9eb..3a98c7e7c743d6c3d2ccbcfe5593d6bb15de5b4d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/services/gcm/InvalidationGcmUpstreamSender.java

@@ -5,6 +5,7 @@

package org.chromium.chrome.browser.services.gcm;

import android.accounts.Account;

+import android.annotation.SuppressLint;

import android.content.Context;

import android.os.AsyncTask;

import android.os.Bundle;

@@ -103,6 +104,8 @@ public class InvalidationGcmUpstreamSender extends GcmUpstreamSenderService {

* Creates and returns a deep copy of the original Bundle.

+ // TODO(crbug.com/635567): Fix this properly.

+ @SuppressLint("ParcelClassLoader")

private Bundle createDeepCopy(Bundle original) {

Parcel temp = Parcel.obtain();

original.writeToParcel(temp, 0);