Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java

Issue 2363113003: Lint suppressions needed for Android SDK roll. (Closed)
Patch Set: Suppress alert box presubmit. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
index db3861c338ff3ce6ba9913636fff1025a4d6a704..f72d0991ece257c1f8dd386c143494b15dc3e7a6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/CreateRouteRequest.java
@@ -4,6 +4,7 @@
package org.chromium.chrome.browser.media.router.cast;
+import android.annotation.SuppressLint;
import android.content.Context;
import android.os.Bundle;
@@ -62,6 +63,8 @@ public class CreateRouteRequest implements GoogleApiClient.ConnectionCallbacks,
}
@Override
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("DefaultLocale")
public void onApplicationDisconnected(int errorCode) {
if (errorCode != CastStatusCodes.SUCCESS) {
Log.e(TAG, String.format(
@@ -249,6 +252,8 @@ public class CreateRouteRequest implements GoogleApiClient.ConnectionCallbacks,
return Cast.CastApi.launchApplication(apiClient, appId, relaunchIfRunning);
}
+ // TODO(crbug.com/635567): Fix this properly.
+ @SuppressLint("DefaultLocale")
private void throwInvalidState() {
throw new RuntimeException(String.format("Invalid state: %d", mState));
}

Powered by Google App Engine
This is Rietveld 408576698