chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java - Issue 2363113003: Lint suppressions needed for Android SDK roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

Issue 2363113003: Lint suppressions needed for Android SDK roll. (Closed)

Patch Set: Suppress alert box presubmit. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

index 886ce1b11e99f6a67f656084968ae7a4012e1fb2..29078598fb9c1cb2b837ea9a283d6e2e7bfa8cea 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java

@@ -4,6 +4,7 @@

package org.chromium.chrome.browser.appmenu;

+import android.annotation.SuppressLint;

import android.app.Activity;

import android.content.res.TypedArray;

import android.graphics.Point;

@@ -77,6 +78,8 @@ public class AppMenuHandler {

* @return True, if the menu is shown, false, if menu is not shown, example reasons:

* the menu is not yet available to be shown, or the menu is already showing.

+ // TODO(crbug.com/635567): Fix this properly.

+ @SuppressLint("ResourceType")

public boolean showAppMenu(View anchorView, boolean startDragging) {

if (!mDelegate.shouldShowAppMenu() || isAppMenuShowing()) return false;

boolean isByPermanentButton = false;