Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: tools/android/checkstyle/chromium-style-5.0.xml

Issue 2363113003: Lint suppressions needed for Android SDK roll. (Closed)
Patch Set: Suppress alert box presubmit. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd"> 2 <!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http: //www.puppycrawl.com/dtds/configuration_1_3.dtd">
3 3
4 <!-- 4 <!--
5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle 5 See installation instructions: https://sites.google.com/a/chromium.org/dev/che ckstyle
6 --> 6 -->
7 <module name="Checker"> 7 <module name="Checker">
8 <property name="severity" value="warning"/> 8 <property name="severity" value="warning"/>
9 <property name="charset" value="UTF-8"/> 9 <property name="charset" value="UTF-8"/>
10 <module name="SuppressionFilter"> 10 <module name="SuppressionFilter">
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 <property name="tokens" value="COMMA"/> 199 <property name="tokens" value="COMMA"/>
200 <property name="option" value="EOL"/> 200 <property name="option" value="EOL"/>
201 </module> 201 </module>
202 <module name="RegexpSinglelineJava"> 202 <module name="RegexpSinglelineJava">
203 <property name="severity" value="error"/> 203 <property name="severity" value="error"/>
204 <property name="format" value="StringBuffer"/> 204 <property name="format" value="StringBuffer"/>
205 <property name="ignoreComments" value="true"/> 205 <property name="ignoreComments" value="true"/>
206 <property name="message" value="Avoid StringBuffer; use StringBuilder inst ead, which is faster (it's not thread-safe, but this is almost never needed)"/> 206 <property name="message" value="Avoid StringBuffer; use StringBuilder inst ead, which is faster (it's not thread-safe, but this is almost never needed)"/>
207 </module> 207 </module>
208 <module name="RegexpSinglelineJava"> 208 <module name="RegexpSinglelineJava">
209 <property name="id" value="AlertDialogCheck"/>
209 <property name="severity" value="warning"/> 210 <property name="severity" value="warning"/>
210 <property name="format" value="android\.app\.AlertDialog"/> 211 <property name="format" value="android\.app\.AlertDialog"/>
211 <property name="ignoreComments" value="true"/> 212 <property name="ignoreComments" value="true"/>
212 <property name="message" value="Avoid android.app.AlertDialog; if possible , use android.support.v7.app.AlertDialog instead, which has a Material look on a ll devices. (Some parts of the codebase can’t depend on the support library, in which case android.app.AlertDialog is the only option)"/> 213 <property name="message" value="Avoid android.app.AlertDialog; if possible , use android.support.v7.app.AlertDialog instead, which has a Material look on a ll devices. (Some parts of the codebase can’t depend on the support library, in which case android.app.AlertDialog is the only option)"/>
213 </module> 214 </module>
214 <module name="RegexpSinglelineJava"> 215 <module name="RegexpSinglelineJava">
215 <property name="id" value="SharedPreferencesCheck"/> 216 <property name="id" value="SharedPreferencesCheck"/>
216 <property name="severity" value="error"/> 217 <property name="severity" value="error"/>
217 <property name="format" value="getDefaultSharedPreferences"/> 218 <property name="format" value="getDefaultSharedPreferences"/>
218 <property name="ignoreComments" value="true"/> 219 <property name="ignoreComments" value="true"/>
219 <property name="message" value="Use ContextUtils.getAppSharedPreferences() instead to access app-wide SharedPreferences."/> 220 <property name="message" value="Use ContextUtils.getAppSharedPreferences() instead to access app-wide SharedPreferences."/>
220 </module> 221 </module>
221 </module> 222 </module>
222 223
223 <!-- Non-TreeWalker modules --> 224 <!-- Non-TreeWalker modules -->
224 <module name="FileTabCharacter"> 225 <module name="FileTabCharacter">
225 <property name="severity" value="error"/> 226 <property name="severity" value="error"/>
226 </module> 227 </module>
227 <module name="RegexpSingleline"> 228 <module name="RegexpSingleline">
228 <property name="severity" value="error"/> 229 <property name="severity" value="error"/>
229 <property name="format" value="[ \t]+$"/> 230 <property name="format" value="[ \t]+$"/>
230 <property name="message" value="Trailing whitespace"/> 231 <property name="message" value="Trailing whitespace"/>
231 </module> 232 </module>
232 <module name="RegexpHeader"> 233 <module name="RegexpHeader">
233 <property name="severity" value="error"/> 234 <property name="severity" value="error"/>
234 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/> 235 <property name="header" value="^// Copyright 20\d\d The Chromium Authors. Al l rights reserved.$\n^// Use of this source code is governed by a BSD-style lice nse that can be$\n^// found in the LICENSE file.$"/>
235 </module> 236 </module>
236 </module> 237 </module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698