Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 2363073003: [inspector] added closure compiler into DEPS (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added closure compiler into DEPS We need this to run checks for debugger-script and injected-script-source. BUG=chromium:645640 R=machenbach@chromium.org Committed: https://crrev.com/93b638ce6a359ca3aa73848e14a5f4ef535d5368 Cr-Commit-Position: refs/heads/master@{#39691}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
A src/inspector/build/closure-compiler.tar.gz.sha1 View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
kozy
Michael, please take a look!
4 years, 2 months ago (2016-09-23 15:53:02 UTC) #1
Michael Achenbach
lgtm
4 years, 2 months ago (2016-09-23 17:37:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363073003/1
4 years, 2 months ago (2016-09-23 19:01:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-23 19:04:58 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 19:05:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93b638ce6a359ca3aa73848e14a5f4ef535d5368
Cr-Commit-Position: refs/heads/master@{#39691}

Powered by Google App Engine
This is Rietveld 408576698