Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2363063002: [turbofan] Handle StringCharCodeAt in escape analysis. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Handle StringCharCodeAt in escape analysis. This adds handling of {IrOpcode::kStringCharCodeAt} nodes to the escape status analysis. Such uses are treated as escaping for now until we add dedicated handling to the escape analysis reducer. R=bmeurer@chromium.org BUG=chromium:649492 Committed: https://chromium.googlesource.com/v8/v8/+/08a441b309d00572e650c020e8a3c45390aa459d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Starzinger
4 years, 2 months ago (2016-09-23 11:06:43 UTC) #1
Benedikt Meurer
LGTM.
4 years, 2 months ago (2016-09-23 11:46:13 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/08a441b309d00572e650c020e8a3c45390aa459d Cr-Commit-Position: refs/heads/master@{#39660}
4 years, 2 months ago (2016-09-23 11:48:48 UTC) #6
Michael Starzinger
4 years, 2 months ago (2016-09-23 11:48:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08a441b309d00572e650c020e8a3c45390aa459d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698