Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2363033002:
[Media Remoting] Add strings. (Closed)
Description[Media Remoting] Add strings.
Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using.
The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. The appropriate strings used in the media layer will be wired up in a later change.
BUG=649575
Committed: https://crrev.com/a96b0198bf79f85271ad24bb61559dfd07ada0a8
Cr-Commit-Position: refs/heads/master@{#420724}
Patch Set 1 #Patch Set 2 : Rebase. #Messages
Total messages: 30 (20 generated)
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== strings BUG= ========== to ========== [Media Remoting] Add strings. Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. BUG=649575 ==========
apacible@chromium.org changed reviewers: + miu@chromium.org, skonig@chromium.org
Description was changed from ========== [Media Remoting] Add strings. Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. BUG=649575 ========== to ========== [Media Remoting] Add strings. Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. The appropriate strings used in the media layer will be wired up in a later change. BUG=649575 ==========
PTAL, thanks! +skonig for strings wording sign off
lgtm, thanks.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
apacible@chromium.org changed reviewers: + xjz@chromium.org
+xjz for committer (to be sure we get it in today :))
lgtm
The CQ bit was checked by apacible@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by apacible@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:20001) has been deleted
The CQ bit was unchecked by apacible@chromium.org
The CQ bit was checked by apacible@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skonig@chromium.org, xjz@chromium.org Link to the patchset: https://codereview.chromium.org/2363033002/#ps40001 (title: "Rebase.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Message was sent while issue was closed.
Description was changed from ========== [Media Remoting] Add strings. Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. The appropriate strings used in the media layer will be wired up in a later change. BUG=649575 ========== to ========== [Media Remoting] Add strings. Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. The appropriate strings used in the media layer will be wired up in a later change. BUG=649575 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Media Remoting] Add strings. Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. The appropriate strings used in the media layer will be wired up in a later change. BUG=649575 ========== to ========== [Media Remoting] Add strings. Add strings from the UX mocks. Some strings are repeats in the file as this gives us full control over the strings we're using. The media layer doesn't access the resource bundle directly, but media/base/media_resources.cc/h and c/c/media/media_resource_provider.cc/h provides indirect access. The appropriate strings used in the media layer will be wired up in a later change. BUG=649575 Committed: https://crrev.com/a96b0198bf79f85271ad24bb61559dfd07ada0a8 Cr-Commit-Position: refs/heads/master@{#420724} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a96b0198bf79f85271ad24bb61559dfd07ada0a8 Cr-Commit-Position: refs/heads/master@{#420724} |
