Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2363003003: Add UMA Metrics For Desktop Share With Audio (Closed)

Created:
4 years, 3 months ago by qiangchen
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA Metrics For Desktop Share With Audio The existing UMA counts "Screen Capturer Creation" and "System Audio Capturer Creation". But based on those two metrics, we have no idea how frequent a stream is created with Screen Share and Audio Share simultaneously. Thus in this CL we add finer metrics "Screen Capturer Created With/Without Audio". Similar situation for tab capture. BUG=649749 Committed: https://crrev.com/dee58c1cfc9a15324facf7cc96ce118e4e51bdb6 Cr-Commit-Position: refs/heads/master@{#420743}

Patch Set 1 : Include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M content/browser/media/capture/desktop_capture_device.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura.cc View 2 chunks +9 lines, -1 line 0 comments Download
M content/browser/media/capture/desktop_capture_device_uma_types.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
qiangchen
Can you take a look at this CL? Thanks.
4 years, 3 months ago (2016-09-23 17:53:25 UTC) #4
Ilya Sherman
histograms.xml lgtm
4 years, 3 months ago (2016-09-23 18:44:28 UTC) #5
DaleCurtis
lgtm
4 years, 3 months ago (2016-09-23 20:51:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363003003/1
4 years, 3 months ago (2016-09-23 20:53:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/205032) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 3 months ago (2016-09-23 21:03:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363003003/20001
4 years, 3 months ago (2016-09-23 21:21:15 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-23 22:35:00 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 22:36:55 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dee58c1cfc9a15324facf7cc96ce118e4e51bdb6
Cr-Commit-Position: refs/heads/master@{#420743}

Powered by Google App Engine
This is Rietveld 408576698