Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2362973002: Change git_url var to chromium_url in DEPS. (Closed)

Created:
4 years, 3 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Change git_url var to chromium_url in DEPS. This makes the variable name for the repo consistent w/ chromium, so that we can use a single variable across repos. R=machenbach@chromium.org Committed: https://crrev.com/faa1ebb319ec5a1003d51338c26391f4499226b0 Cr-Commit-Position: refs/heads/master@{#39698}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M DEPS View 1 1 chunk +21 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dirk Pranke
4 years, 3 months ago (2016-09-23 00:25:44 UTC) #1
Michael Achenbach
lgtm
4 years, 3 months ago (2016-09-23 13:39:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362973002/1
4 years, 3 months ago (2016-09-23 17:03:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9549)
4 years, 3 months ago (2016-09-23 17:04:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362973002/20001
4 years, 3 months ago (2016-09-23 23:29:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 23:54:41 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 23:54:58 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/faa1ebb319ec5a1003d51338c26391f4499226b0
Cr-Commit-Position: refs/heads/master@{#39698}

Powered by Google App Engine
This is Rietveld 408576698