Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2362963002: Do not include fileBrowserHandler schema definition in non-chromeos. (Closed)

Created:
4 years, 3 months ago by lazyboy
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not include fileBrowserHandler schema definition in non-chromeos. In CL https://crrev.com/2344783004, I've made compile exclude custom bindings of fileBrowserHandler in non-chromeos builds. However, it seems I've missed the schema definition file itself, this CL does that. BUG=376319 Test=No visible change, dev only instruction: You can test it by compiling chrome: 1. In non-chromeos build chrome target. 2. Inspect out/Debug/gen/chrome/common/extensions/api/generated_schemas.cc 3. There shouldn't be any entry for fileBrowserHandler any more (just search for the string). If you build chromeos instead, you should see kFileBrowserHandler and its friends (e.g. kFileBrowserHandlerInternal). Committed: https://crrev.com/c9f955347ebd914373fd1c41b12b8e4ea3dfc159 Cr-Commit-Position: refs/heads/master@{#420531}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/common/extensions/api/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
lazyboy
A quick follow up from one of my previous CL.
4 years, 3 months ago (2016-09-22 23:29:19 UTC) #4
asargent_no_longer_on_chrome
lgtm
4 years, 3 months ago (2016-09-22 23:36:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362963002/1
4 years, 3 months ago (2016-09-23 01:10:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-23 01:17:17 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 01:19:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9f955347ebd914373fd1c41b12b8e4ea3dfc159
Cr-Commit-Position: refs/heads/master@{#420531}

Powered by Google App Engine
This is Rietveld 408576698