Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 2362923002: New test expectations for async function callstack tests (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
kozy, gsathya
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, jgruber, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

New test expectations for async function callstack tests Async/await functions are getting better stack traces from the V8 patch at https://codereview.chromium.org/2357423002/ . This patch checks in new test expectations and marks the tests as NeedsManualRebaseline until the V8 patch is checked in and the roll occurs. BUG=v8:4483, chromium:646199 Committed: https://crrev.com/ce1a9526d762f50324b4202a32eebe085b810cc8 Cr-Commit-Position: refs/heads/master@{#420778}

Patch Set 1 #

Patch Set 2 : Additional duplicate stack frames for entering the async function #

Messages

Total messages: 8 (3 generated)
Dan Ehrenberg
4 years, 3 months ago (2016-09-22 22:32:25 UTC) #2
kozy
lgtm
4 years, 3 months ago (2016-09-23 21:54:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362923002/20001
4 years, 3 months ago (2016-09-23 21:55:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-23 23:21:30 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 23:24:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce1a9526d762f50324b4202a32eebe085b810cc8
Cr-Commit-Position: refs/heads/master@{#420778}

Powered by Google App Engine
This is Rietveld 408576698