Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: trunk/src/tools/telemetry/telemetry/core/browser_options.py

Issue 23629037: Revert 222145 "keep_test_server_ports to BrowserOptions (this sh..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/telemetry/telemetry/core/browser_options.py
===================================================================
--- trunk/src/tools/telemetry/telemetry/core/browser_options.py (revision 222218)
+++ trunk/src/tools/telemetry/telemetry/core/browser_options.py (working copy)
@@ -73,6 +73,11 @@
dest='android_device',
help='The android device ID to use'
'If not specified, only 0 or 1 connected devcies are supported.')
+ group.add_option('--keep_test_server_ports', action='store_true',
+ help='Indicates the test server ports must be '
+ 'kept. When this is run via a sharder '
+ 'the test server ports should be kept and '
+ 'should not be reset.')
group.add_option(
'--remote',
dest='cros_remote',
@@ -207,8 +212,6 @@
self.no_proxy_server = False
self.browser_user_agent_type = None
- self.keep_test_server_ports = False
-
self.clear_sytem_cache_for_browser_and_profile_on_start = False
def AddCommandLineOptions(self, parser):
@@ -237,15 +240,6 @@
help='When possible, will display the stdout of the process')
parser.add_option_group(group)
- # Android options. TODO(achuith): Move to AndroidBrowserOptions.
- group = optparse.OptionGroup(parser, 'Android options')
- group.add_option('--keep_test_server_ports',
- action='store_true',
- help='Indicates the test server ports must be kept. When this is run '
- 'via a sharder the test server ports should be kept and should '
- 'not be reset.')
- parser.add_option_group(group)
-
def UpdateFromParseResults(self, finder_options):
"""Copies our options from finder_options"""
browser_options_list = [
« no previous file with comments | « trunk/src/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698