Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23629033: Fix a crash in the FileSystem API when the app window closes during a call. (Closed)

Created:
7 years, 3 months ago by Sam McNally
Modified:
7 years, 3 months ago
Reviewers:
benwells
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix a crash in the FileSystem API when the app window closes during a call. Previously, closing the app window while a file is being checked for write access caused a crash. This adds an early exit to prevent that crash. BUG=282727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222224

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sam McNally
7 years, 3 months ago (2013-09-09 23:22:14 UTC) #1
benwells
https://codereview.chromium.org/23629033/diff/4001/chrome/browser/extensions/api/file_system/file_system_api.cc File chrome/browser/extensions/api/file_system/file_system_api.cc (right): https://codereview.chromium.org/23629033/diff/4001/chrome/browser/extensions/api/file_system/file_system_api.cc#newcode167 chrome/browser/extensions/api/file_system/file_system_api.cc:167: DCHECK(render_view_host); Why add all these DCHECKs?
7 years, 3 months ago (2013-09-10 00:47:13 UTC) #2
Sam McNally
https://codereview.chromium.org/23629033/diff/4001/chrome/browser/extensions/api/file_system/file_system_api.cc File chrome/browser/extensions/api/file_system/file_system_api.cc (right): https://codereview.chromium.org/23629033/diff/4001/chrome/browser/extensions/api/file_system/file_system_api.cc#newcode167 chrome/browser/extensions/api/file_system/file_system_api.cc:167: DCHECK(render_view_host); On 2013/09/10 00:47:14, benwells wrote: > Why add ...
7 years, 3 months ago (2013-09-10 01:04:13 UTC) #3
benwells
lgtm
7 years, 3 months ago (2013-09-10 01:31:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/23629033/13001
7 years, 3 months ago (2013-09-10 01:35:03 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-10 02:08:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/23629033/13001
7 years, 3 months ago (2013-09-10 05:29:37 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 08:48:16 UTC) #8
Message was sent while issue was closed. 
Change committed as 222224

Powered by Google App Engine
This is Rietveld 408576698