Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: chrome/browser/extensions/extension_service.h

Issue 23629027: Add a hack to allow us to disable extension garbage collection. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.h
diff --git a/chrome/browser/extensions/extension_service.h b/chrome/browser/extensions/extension_service.h
index 01fabca9f20b96d4364c650723413a1406a0031f..40093093876c8674e35442359228421c8df46d4e 100644
--- a/chrome/browser/extensions/extension_service.h
+++ b/chrome/browser/extensions/extension_service.h
@@ -695,6 +695,15 @@ class ExtensionService
// sync_start_util for more.
void SetSyncStartFlare(const syncer::SyncableService::StartSyncFlare& flare);
+#if defined(OS_CHROMEOS)
+ void disable_garbage_collection() {
+ disable_garbage_collection_ = true;
+ }
+ void enable_garbage_collection() {
+ disable_garbage_collection_ = false;
+ }
+#endif
+
private:
// Contains Extension data that can change during the life of the process,
// but does not persist across restarts.
@@ -960,6 +969,14 @@ class ExtensionService
// asynchronously via MergeDataAndStartSyncing as soon as possible.
syncer::SyncableService::StartSyncFlare flare_;
+#if defined(OS_CHROMEOS)
+ // TODO(rkc): HACK alert - this is only in place to allow the
+ // kiosk_mode_screensaver to prevent its extension from getting garbage
+ // collected. Remove this once KioskModeScreensaver is removed.
+ // See crbug.com/263582
asargent_no_longer_on_chrome 2013/09/04 23:09:01 nit: is this the right bug id? The referenced bug
rkc 2013/09/04 23:11:56 Copy/paste derp. Fixed. Done.
+ bool disable_garbage_collection_;
+#endif
+
FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
InstallAppsWithUnlimtedStorage);
FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,

Powered by Google App Engine
This is Rietveld 408576698