Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 23629023: Update NaCl technical overview for the PNaCl world (Closed)

Created:
7 years, 3 months ago by eliben
Modified:
7 years, 3 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

This updates the Native Client technical overview to the new bright world of PNaCl. As discussed in the team meeting, I'm still focusing on Native Client as the umbrella name for the technology, but trying to present PNaCl as the default toolchain. This update also removes some duplication from the document (with itself and with other documents), and introduces new, consistent diagrams. The other documents touched are just adding placeholders for links to look nicely in rendering. It's still rough along the edges and has some TODOs, but I think it's ready for an initial review. BUG=None R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221511

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : More fixes + a new image #

Total comments: 33

Patch Set 4 : After Ben's review #

Patch Set 5 : Fix Ben's review #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -327 lines) Patch
A native_client_sdk/src/doc/devguide/coding/3D-graphics.rst View 1 1 chunk +8 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/coding/FileIO.rst View 1 1 chunk +8 lines, -0 lines 0 comments Download
A native_client_sdk/src/doc/devguide/coding/audio.rst View 1 1 chunk +8 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/devguide/coding/message-system.rst View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
A native_client_sdk/src/doc/images/nacl-in-a-web-app.png View 1 2 Binary file 0 comments Download
A native_client_sdk/src/doc/images/nacl-pnacl-component-diagram.png View 1 Binary file 0 comments Download
A native_client_sdk/src/doc/images/web-app-with-nacl.png View 1 Binary file 0 comments Download
M native_client_sdk/src/doc/index.rst View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/doc/overview.rst View 1 2 3 4 2 chunks +191 lines, -325 lines 0 comments Download
A native_client_sdk/src/doc/sdk/index.rst View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eliben
7 years, 3 months ago (2013-09-04 20:40:48 UTC) #1
binji
https://codereview.chromium.org/23629023/diff/8001/native_client_sdk/src/doc/overview.rst File native_client_sdk/src/doc/overview.rst (right): https://codereview.chromium.org/23629023/diff/8001/native_client_sdk/src/doc/overview.rst#newcode45 native_client_sdk/src/doc/overview.rst:45: give C and C++ (and eventually other languages) the ...
7 years, 3 months ago (2013-09-04 21:51:07 UTC) #2
eliben
https://codereview.chromium.org/23629023/diff/8001/native_client_sdk/src/doc/overview.rst File native_client_sdk/src/doc/overview.rst (right): https://codereview.chromium.org/23629023/diff/8001/native_client_sdk/src/doc/overview.rst#newcode45 native_client_sdk/src/doc/overview.rst:45: give C and C++ (and eventually other languages) the ...
7 years, 3 months ago (2013-09-05 18:15:31 UTC) #3
binji
lgtm https://codereview.chromium.org/23629023/diff/8001/native_client_sdk/src/doc/overview.rst File native_client_sdk/src/doc/overview.rst (right): https://codereview.chromium.org/23629023/diff/8001/native_client_sdk/src/doc/overview.rst#newcode45 native_client_sdk/src/doc/overview.rst:45: give C and C++ (and eventually other languages) ...
7 years, 3 months ago (2013-09-05 20:28:58 UTC) #4
eliben
> https://codereview.chromium.org/23629023/diff/8001/native_client_sdk/src/doc/overview.rst#newcode139 > native_client_sdk/src/doc/overview.rst:139: These come in addition to the > existing sandbox in the ...
7 years, 3 months ago (2013-09-05 20:43:57 UTC) #5
eliben
Committed patchset #5 manually as r221511 (presubmit successful).
7 years, 3 months ago (2013-09-05 20:53:07 UTC) #6
eliben
7 years, 3 months ago (2013-09-06 17:24:51 UTC) #7
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698