Issue 23629018: DevTools: show styles for shadow dom elements

Issue 23629018: DevTools: show styles for shadow dom elements (Closed)

Created:
7 years, 3 months ago by lushnikov

Modified:
7 years, 2 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, darktears, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: show styles for shadow dom elements This patch fixes a bug which prevented devTools from showing styles for shadow dom elements. BUG=279390 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160328

Patch Set 1 #

Patch Set 2 : small fix #

Patch Set 3 : Rebaselined, refactored #

Patch Set 4 : adding tests #

Patch Set 5 : fix nits #

Patch Set 6 : fix inspector-enabled test #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -19 lines)			Patch
A	LayoutTests/http/tests/inspector-enabled/shadow-dom-rules.html	View	1 2 3 4 5	1 chunk	+50 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/inspector-enabled/shadow-dom-rules-expected.txt	View	1 2 3 4	1 chunk	+19 lines, -0 lines	0 comments	Download
A +	LayoutTests/inspector/styles/shadow-dom-rules.html	View	1 2 3 4	3 chunks	+12 lines, -15 lines	0 comments	Download
A	LayoutTests/inspector/styles/shadow-dom-rules-expected.txt	View	1 2 3 4	1 chunk	+19 lines, -0 lines	0 comments	Download
M	Source/core/css/InspectorCSSOMWrappers.cpp	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1 2	1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

On 2013/09/03 16:25:39, lushnikov wrote: lets not land this. we need to fix styles inspection ...

7 years, 3 months ago (2013-09-04 15:28:25 UTC) #2

lushnikov

On 2013/10/22 19:10:04, pfeldman wrote: > This works on ToT, requires a test to land. ...

7 years, 2 months ago (2013-10-23 09:27:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/23629018/136001

7 years, 2 months ago (2013-10-23 09:49:31 UTC) #6

Message was sent while issue was closed.

Change committed as 160328

Expand Messages | Collapse Messages