Issue 23629011: Make StyleSheetList.item() index argument mandatory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23629011: Make StyleSheetList.item() index argument mandatory (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
tkent, arv (Not doing code reviews)

CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, do-not-use, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Make StyleSheetList.item() index argument mandatory Make StyleSheetList.item() index argument mandatory to match the specification: http://www.w3.org/TR/2000/CR-DOM-Level-2-20000510/stylesheets.html#StyleSheets-StyleSheetList This behavior is consistent with Firefox 23. The argument is however optional in IE10, which is uncommon for an indexed getter. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157054

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/StyleSheetList.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

do-not-use

Validated on Firefox and IE using: http://jsfiddle.net/PsM5T/2/

7 years, 3 months ago (2013-08-30 13:07:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23629011/1

7 years, 3 months ago (2013-09-02 02:19:46 UTC) #4

Message was sent while issue was closed.

Change committed as 157054