internet_detail.js: Handle undefined APN fields.

internet_detail.js: Fix errors in cellular APN selection UI.

This CL fixes the following bugs in the cellular APN setting UI.:

  1. The first time the user brings up the custom APN UI, the APN input field
     contents were being set to "undefined". Fixed this.
  2. After setting a custom APN, if the user ever reverted to the default APN,
     and if the default APN did not contain a username/password field, the
     username and password fields of the Cellular.APN property were being set
     to "undefined" and this was getting stored in the profile.
  3. The JS now caches the APN fields set by the user so that the user can now
     switch back and forth between the default and the selected APNs. Before,
     trying to select the user APN via the drop-down menu resulted in the wrong
     APN to be set.

BUG=282711
R=stevenjb@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221524

[stevenjb, 2013-08-30 16:34:04]

https://codereview.chromium.org/23629010/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/23629010/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/chromeos/internet_detail.js:199:
data.apn.password = apn.password ? String(apn.password) : '';
Seems like this could all be simplified with a helper method like:
data.apn.apn = StringFromField($('cellular-apn').value);
Where StringFromField would look something like:
StringFromField(field) {
  return field ? String(field) : '';
}

https://codereview.chromium.org/23629010/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/chromeos/internet_detail.js:237: };
Rather than using this, could just use
StringFromField(apnList[apnSelector.selectedIndex].apn), etc below.

[armansito, 2013-08-30 23:55:19]

https://codereview.chromium.org/23629010/diff/1/chrome/browser/resources/opti...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/23629010/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/chromeos/internet_detail.js:199:
data.apn.password = apn.password ? String(apn.password) : '';
On 2013/08/30 16:34:05, stevenjb (chromium) wrote:
> Seems like this could all be simplified with a helper method like:
> data.apn.apn = StringFromField($('cellular-apn').value);
> Where StringFromField would look something like:
> StringFromField(field) {
>   return field ? String(field) : '';
> }

Done.

https://codereview.chromium.org/23629010/diff/1/chrome/browser/resources/opti...
chrome/browser/resources/options/chromeos/internet_detail.js:237: };
On 2013/08/30 16:34:05, stevenjb (chromium) wrote:
> Rather than using this, could just use
> StringFromField(apnList[apnSelector.selectedIndex].apn), etc below.

Done.

[armansito, 2013-08-31 00:18:23]

ptal

[stevenjb, 2013-09-03 21:44:32]

lgtm

https://codereview.chromium.org/23629010/diff/9001/chrome/browser/resources/o...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/23629010/diff/9001/chrome/browser/resources/o...
chrome/browser/resources/options/chromeos/internet_detail.js:208: };
nit/question: Could this just be data.userApn = data.apn?

[armansito, 2013-09-03 22:07:38]

https://codereview.chromium.org/23629010/diff/9001/chrome/browser/resources/o...
File chrome/browser/resources/options/chromeos/internet_detail.js (right):

https://codereview.chromium.org/23629010/diff/9001/chrome/browser/resources/o...
chrome/browser/resources/options/chromeos/internet_detail.js:208: };
On 2013/09/03 21:44:32, stevenjb (chromium) wrote:
> nit/question: Could this just be data.userApn = data.apn?

I think the code just modifies data.apn instead of creating it from scratch
every time the user sets it. So, we either change that to create a new
dictionary for data.apn every time, or we make a deep copy here. I chose to do a
deep copy here as it seemed simpler to me.

We should probably make this code more modular in general as you rewrite the
Settings UI (with more helpers and better documentation). Also, feel free to
assign any bugs for reimplementing cellular-specific pieces of the new Settings
UI to me (such as APN and SIM unlock). Hopefully we'll have the missing
networkingPrivate pieces ready by then, which is next on my plate.

[armansito, 2013-09-05 21:45:58]

Committed patchset #6 manually as r221524 (presubmit successful).