Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2362893003: CL for src perf tryjob to run smoothness.tough_animation_cases benchmark on linux platform(s)
Patch Set: CL for src perf tryjob to run smoothness.tough_animation_cases benchmark on all-win platform(s) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
index 13087ebb9e5028c08d8540cae7bd85d5381a7f81..ee4264e74a2fe61e8fec7cf6dbea84117375b860 100644
--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
@@ -550,17 +550,13 @@ static CSSValueList* valuesForBackgroundShorthand(const ComputedStyle& style, co
return ret;
}
-static CSSValueList* valueForContentPositionAndDistributionWithOverflowAlignment(const StyleContentAlignmentData& data, CSSValueID normalBehaviorValueID)
+static CSSValueList* valueForContentPositionAndDistributionWithOverflowAlignment(const StyleContentAlignmentData& data)
{
CSSValueList* result = CSSValueList::createSpaceSeparated();
if (data.distribution() != ContentDistributionDefault)
result->append(*CSSPrimitiveValue::create(data.distribution()));
- if (data.distribution() == ContentDistributionDefault || data.position() != ContentPositionNormal) {
- if (!RuntimeEnabledFeatures::cssGridLayoutEnabled() && data.position() == ContentPositionNormal)
- result->append(*CSSPrimitiveValue::createIdentifier(normalBehaviorValueID));
- else
- result->append(*CSSPrimitiveValue::create(data.position()));
- }
+ if (data.distribution() == ContentDistributionDefault || data.position() != ContentPositionNormal)
+ result->append(*CSSPrimitiveValue::create(data.position()));
if ((data.position() >= ContentPositionCenter || data.distribution() != ContentDistributionDefault) && data.overflow() != OverflowAlignmentDefault)
result->append(*CSSPrimitiveValue::create(data.overflow()));
ASSERT(result->length() > 0);
@@ -1895,7 +1891,7 @@ const CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, cons
case CSSPropertyEmptyCells:
return CSSPrimitiveValue::create(style.emptyCells());
case CSSPropertyAlignContent:
- return valueForContentPositionAndDistributionWithOverflowAlignment(style.alignContent(), CSSValueStretch);
+ return valueForContentPositionAndDistributionWithOverflowAlignment(style.alignContent());
case CSSPropertyAlignItems:
return valueForItemPositionWithOverflowAlignment(style.alignItems());
case CSSPropertyAlignSelf:
@@ -1915,7 +1911,7 @@ const CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, cons
case CSSPropertyFlexWrap:
return CSSPrimitiveValue::create(style.flexWrap());
case CSSPropertyJustifyContent:
- return valueForContentPositionAndDistributionWithOverflowAlignment(style.justifyContent(), CSSValueFlexStart);
+ return valueForContentPositionAndDistributionWithOverflowAlignment(style.justifyContent());
case CSSPropertyOrder:
return CSSPrimitiveValue::create(style.order(), CSSPrimitiveValue::UnitType::Number);
case CSSPropertyFloat:

Powered by Google App Engine
This is Rietveld 408576698