Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2362873002: Add some errors related to nnbd (Closed)

Created:
4 years, 3 months ago by Brian Wilkerson
Modified:
4 years, 3 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fixed error range #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -181 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 6 chunks +47 lines, -8 lines 2 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 23 chunks +298 lines, -173 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
I also cleaned up some test code; I'm happy to split the CL if you'd ...
4 years, 3 months ago (2016-09-22 20:27:45 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2362873002/diff/20001/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/2362873002/diff/20001/pkg/analyzer/lib/src/generated/parser.dart#newcode8657 pkg/analyzer/lib/src/generated/parser.dart:8657: "A nullable type cannot be used in an ...
4 years, 3 months ago (2016-09-22 20:30:43 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2362873002/diff/20001/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/2362873002/diff/20001/pkg/analyzer/lib/src/generated/parser.dart#newcode8657 pkg/analyzer/lib/src/generated/parser.dart:8657: "A nullable type cannot be used in an with ...
4 years, 3 months ago (2016-09-22 20:43:13 UTC) #4
Brian Wilkerson
4 years, 3 months ago (2016-09-22 20:43:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fd7bb76a4b0aff4c4884947869a254eab0887686 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698