Issue 23628009: suppress data race at ServerLicensingOpenW

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23628009: suppress data race at ServerLicensingOpenW (Closed)

Created:
7 years, 3 months ago by zhaoqin

Modified:
7 years, 3 months ago

Reviewers:
DaleCurtis, the_wrong_timurrrr_2

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

suppress data race at ServerLicensingOpenW TBR=dalecurtis@chromium.org BUG=287796 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222020

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -0 lines)			Patch
	M	tools/valgrind/tsan/suppressions_win32.txt	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

the_wrong_timurrrr_2

Can you please check whether ServerLicensingOpenW requires external synchronization? Could it have something like a ...

7 years, 3 months ago (2013-09-09 13:52:42 UTC) #2

zhaoqin

Committed patchset #1 manually as r222020 (presubmit successful).

7 years, 3 months ago (2013-09-09 13:54:09 UTC) #3

zhaoqin

I am not sure what "double-checked locking" means. On Mon, Sep 9, 2013 at 9:52 ...

7 years, 3 months ago (2013-09-09 17:15:34 UTC) #4

the_wrong_timurrrr_2

7 years, 3 months ago (2013-09-09 19:07:56 UTC) #5

It's a common threading pattern

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages